You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/27 16:45:18 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request #357: Remove Persistence option for SolrBackup.
HoustonPutman opened a new pull request #357:
URL: https://github.com/apache/solr-operator/pull/357
#347
TODO list:
- [ ] Upgrade docs & ChangeLog entry
- [ ] Local Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on a change in pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r740304414
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -1106,7 +1106,7 @@ spec:
description: Whether the backup has finished
type: boolean
persistenceStatus:
- description: Whether the backups are in progress of being persisted
+ description: 'Whether the backups are in progress of being persisted. This feature has been removed as of v0.5.0. TODO: Remove this field entirely in v0.6.0'
Review comment:
[0] ditto re: maybe the TODO should be a comment?
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified backup repository.
type: string
persistence:
- description: Persistence is the specification on how to persist the backup data.
+ description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0'
Review comment:
[0] It's a little odd to see a TODO comment in what (I think?) is user-facing documentation. Should this be in a `#`-based YAML comment instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified backup repository.
type: string
persistence:
- description: Persistence is the specification on how to persist the backup data.
+ description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0'
Review comment:
Fair enough on removing the TODO, because we might want to leave in the field anyways (for yaml back-compat).
These files are auto-generated by `make manifests` after you edit anything in the `api/` package. So we can't really add yaml comments here. These descriptions are taken from the comments before the property in the struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on a change in pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r740304414
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -1106,7 +1106,7 @@ spec:
description: Whether the backup has finished
type: boolean
persistenceStatus:
- description: Whether the backups are in progress of being persisted
+ description: 'Whether the backups are in progress of being persisted. This feature has been removed as of v0.5.0. TODO: Remove this field entirely in v0.6.0'
Review comment:
[0] ditto re: maybe the TODO should be a comment?
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified backup repository.
type: string
persistence:
- description: Persistence is the specification on how to persist the backup data.
+ description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0'
Review comment:
[0] It's a little odd to see a TODO comment in what (I think?) is user-facing documentation. Should this be in a `#`-based YAML comment instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #357:
URL: https://github.com/apache/solr-operator/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #357:
URL: https://github.com/apache/solr-operator/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #357:
URL: https://github.com/apache/solr-operator/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified backup repository.
type: string
persistence:
- description: Persistence is the specification on how to persist the backup data.
+ description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0'
Review comment:
Fair enough on removing the TODO, because we might want to leave in the field anyways (for yaml back-compat).
These files are auto-generated by `make manifests` after you edit anything in the `api/` package. So we can't really add yaml comments here. These descriptions are taken from the comments before the property in the struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #357:
URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -71,7 +71,7 @@ spec:
description: The location to store the backup in the specified backup repository.
type: string
persistence:
- description: Persistence is the specification on how to persist the backup data.
+ description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0'
Review comment:
Fair enough on removing the TODO, because we might want to leave in the field anyways (for yaml back-compat).
These files are auto-generated by `make manifests` after you edit anything in the `api/` package. So we can't really add yaml comments here. These descriptions are taken from the comments before the property in the struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org