You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "justinwwhuang (via GitHub)" <gi...@apache.org> on 2024/12/02 08:01:26 UTC
[PR] [INLONG-11569][Agent] Add COS Task [inlong]
justinwwhuang opened a new pull request, #11570:
URL: https://github.com/apache/inlong/pull/11570
Fixes #11569
### Motivation
Add COS Task
### Modifications
1. Add COS related macro definitions
2. Add COS type task class
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
No doc needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11569][Agent] Add COS Task [inlong]
Posted by "justinwwhuang (via GitHub)" <gi...@apache.org>.
justinwwhuang merged PR #11570:
URL: https://github.com/apache/inlong/pull/11570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11569][Agent] Add COS Task [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #11570:
URL: https://github.com/apache/inlong/pull/11570#discussion_r1865413886
##########
inlong-common/src/main/java/org/apache/inlong/common/enums/TaskTypeEnum.java:
##########
@@ -44,11 +44,11 @@ public enum TaskTypeEnum {
REDIS(11),
MQTT(12),
HUDI(13),
+ COS(14),
+ HA_BINLOG(101),
Review Comment:
This value is not used anywhere, please delete it.
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/TaskProfileDto.java:
##########
@@ -544,6 +580,15 @@ public static TaskProfile convertToTaskProfile(DataConfig dataConfig) {
case MOCK:
profileDto.setTask(task);
break;
+ case COS:
+ task.setTaskClass(DEFAULT_COS_TASK);
+ COSTask cosTask = getCOSTask(dataConfig);
+ task.setCycleUnit(cosTask.getCycleUnit());
+ task.setCosTask(cosTask);
+ task.setSource(COS_SOURCE);
+ task.setRetry(cosTask.getRetry());
+ profileDto.setTask(task);
+ break;
default:
Review Comment:
By default, no action has been taken. Please add a log or throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org