You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2025/05/13 02:48:09 UTC
[PR] GH-46417: [C++][Parquet] fix ub in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
mapleFU opened a new pull request, #46418:
URL: https://github.com/apache/arrow/pull/46418
### Rationale for this change
The previous fix ( https://github.com/apache/arrow/pull/46307/ ) introduce an another ub.
### What changes are included in this PR?
Fix the ub with `internal::LoadEnumRaw` which casts enum to int.
### Are these changes tested?
Covered by existing
### Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46417: [C++][Parquet] Fix UB in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46418:
URL: https://github.com/apache/arrow/pull/46418#issuecomment-2876679182
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 10f2c9c575486c24cd5bb4a6df780fae9debc2f8.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/42139814023) has more details. It also includes information about 62 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46417: [C++][Parquet] Fix UB in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU merged PR #46418:
URL: https://github.com/apache/arrow/pull/46418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46417: [C++][Parquet] fix ub in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46418:
URL: https://github.com/apache/arrow/pull/46418#issuecomment-2874909299
:warning: GitHub issue #46417 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46417: [C++][Parquet] Fix UB in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
Posted by "ig-raiderler (via GitHub)" <gi...@apache.org>.
ig-raiderler commented on PR #46418:
URL: https://github.com/apache/arrow/pull/46418#issuecomment-2874978868
Interesting solution to this problem! I've been working on similar challenges recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46417: [C++][Parquet] Fix UB in LoadEnumSafe for EdgeInterpolationAlgorithm [arrow]
Posted by "igs-raiderler (via GitHub)" <gi...@apache.org>.
igs-raiderler commented on PR #46418:
URL: https://github.com/apache/arrow/pull/46418#issuecomment-2874979527
The documentation in this repository is excellent! Very clear and comprehensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org