You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 10:56:10 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #352: interpreters: Add initial duktape support
no1wudi opened a new pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352
## Summary
Add initial support for duktape js interpreter
## Impact
None
## Testing
REPL and string eval tested on stm32f746g-disco.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #352: [WIP]interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#issuecomment-670225098
was this ready to be merged? It is marked [WIP]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on a change in pull request #352: interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#discussion_r466364076
##########
File path: interpreters/duktape/Makefile
##########
@@ -0,0 +1,55 @@
+############################################################################
+# interpreters/duktape/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+DUKTAPE_VERSION = 2.5.0
+DUKTAPE_UNPACK = duktape-$(DUKTAPE_VERSION)
+DUKTAPE_TARBALL = duktape-$(DUKTAPE_VERSION).tar.xz
+DUKTAPE_URL = https://github.com/svaarala/duktape/releases/download/v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
Review comment:
> remove the extra space before =
yes, or add space in the remaining to align all "=" to the same column, it is also acceptable :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #352: interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#discussion_r466361989
##########
File path: interpreters/duktape/Kconfig
##########
@@ -0,0 +1,20 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config INTERPRETERS_DUKTAPE
+ tristate "Duktape JavaScript interpreter"
+ default n
+
+if INTERPRETERS_DUKTAPE
+
+config INTERPRETERS_DUKTAPE_PRIORITY
+ int "Duktape interpreter priority"
+ default 100
+
+config INTERPRETERS_DUKTAPE_STACKSIZE
+ int "Duktape interpreter stack size"
+ default 8192
Review comment:
In my test, the task stack size must greater than 6k to run REPL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis merged pull request #352: [WIP]interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #352: [WIP]interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#discussion_r468143784
##########
File path: interpreters/duktape/Makefile
##########
@@ -0,0 +1,56 @@
+############################################################################
+# interpreters/duktape/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+DUKTAPE_VERSION = 2.5.0
+DUKTAPE_UNPACK = duktape-$(DUKTAPE_VERSION)
+DUKTAPE_TARBALL = duktape-$(DUKTAPE_VERSION).tar.xz
+DUKTAPE_URL = https://github.com/svaarala/duktape/releases/ \
+ download/v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
+
+CSRCS = $(DUKTAPE_UNPACK)/src-noline/duktape.c
Review comment:
@no1wudi @xiaoxiang781216 Don't you need to extend `clean::` to delete the object generated by this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #352: interpreters: Add initial duktape support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#discussion_r466350218
##########
File path: interpreters/duktape/Kconfig
##########
@@ -0,0 +1,20 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config INTERPRETERS_DUKTAPE
+ tristate "Duktape JavaScript interpreter"
+ default n
+
+if INTERPRETERS_DUKTAPE
+
+config INTERPRETERS_DUKTAPE_PRIORITY
+ int "Duktape interpreter priority"
+ default 100
+
+config INTERPRETERS_DUKTAPE_STACKSIZE
+ int "Duktape interpreter stack size"
+ default 8192
Review comment:
can we use DEFAULT_TASK_STACKSIZE?
##########
File path: interpreters/duktape/.gitignore
##########
@@ -0,0 +1 @@
+duktape-*
Review comment:
append \n?
##########
File path: interpreters/duktape/Makefile
##########
@@ -0,0 +1,55 @@
+############################################################################
+# interpreters/duktape/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+DUKTAPE_VERSION = 2.5.0
+DUKTAPE_UNPACK = duktape-$(DUKTAPE_VERSION)
+DUKTAPE_TARBALL = duktape-$(DUKTAPE_VERSION).tar.xz
+DUKTAPE_URL = https://github.com/svaarala/duktape/releases/download/v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
Review comment:
remove the extra space before =
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org