You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/09/09 12:53:03 UTC

[GitHub] [brooklyn-server] ahgittin opened a new pull request #1255: Unmanagement tidy up

ahgittin opened a new pull request #1255:
URL: https://github.com/apache/brooklyn-server/pull/1255


   Cleans up various things noticed when using hot_standby and switching management nodes a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] algairim commented on a change in pull request #1255: Unmanagement tidy up

Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1255:
URL: https://github.com/apache/brooklyn-server/pull/1255#discussion_r705313863



##########
File path: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java
##########
@@ -393,7 +393,8 @@ protected void manageRecursive(Entity e, final ManagementTransitionMode initialM
             if (mode==null) {
                 setManagementTransitionMode(it, mode = initialMode);
             }
-            
+            log.debug("Starting management of {} mode {}", it, mode);

Review comment:
       No, this is supposed to be 'mode'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] iuliana commented on a change in pull request #1255: Unmanagement tidy up

Posted by GitBox <gi...@apache.org>.
iuliana commented on a change in pull request #1255:
URL: https://github.com/apache/brooklyn-server/pull/1255#discussion_r705309654



##########
File path: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java
##########
@@ -393,7 +393,8 @@ protected void manageRecursive(Entity e, final ManagementTransitionMode initialM
             if (mode==null) {
                 setManagementTransitionMode(it, mode = initialMode);
             }
-            
+            log.debug("Starting management of {} mode {}", it, mode);

Review comment:
       of 'node' you mean :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] asfgit closed pull request #1255: Unmanagement tidy up

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1255:
URL: https://github.com/apache/brooklyn-server/pull/1255


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org