You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/30 19:00:16 UTC
[GitHub] [airflow] omarismail94 opened a new pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Datraproc on GKE
omarismail94 opened a new pull request #11210:
URL: https://github.com/apache/airflow/pull/11210
Change job submission template from underscores to dashes to conform with k8s naming convention for Datraproc on GKE [1]
Rn, if you submit a job with the `DataProcPySparkOperator` to a Dataproc cluster running on GKE, the job fails to launch due to tis issue
[1] https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/dataproc.py#L196
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Dataproc on GKE
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #11210:
URL: https://github.com/apache/airflow/pull/11210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Datraproc on GKE
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11210:
URL: https://github.com/apache/airflow/pull/11210#issuecomment-701582358
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] omarismail94 commented on pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Dataproc on GKE
Posted by GitBox <gi...@apache.org>.
omarismail94 commented on pull request #11210:
URL: https://github.com/apache/airflow/pull/11210#issuecomment-738863901
@turbaszek Sorry for the late response!
Isn't the `airflow/providers/google/cloud/hooks/dataproc.py` path not the deprecated one? I thought the `contrib.` was deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Dataproc on GKE
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11210:
URL: https://github.com/apache/airflow/pull/11210#issuecomment-740513190
> @turbaszek Sorry for the late response!
>
> Isn't the `airflow/providers/google/cloud/hooks/dataproc.py` path not the deprecated one? I thought the `contrib.` was deprecated.
Contrib is deprecated but some moved operators are also deprecated in providers. In this way we were able to keep backward compatibility. The main idea in Dataproc is to have generic `DataprocSubmitJobOperator` instead of operator-per job type - that's more aligned with the Google API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Dataproc on GKE
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11210:
URL: https://github.com/apache/airflow/pull/11210#issuecomment-706728857
I restarted the CI. The changes looks good to me however, all changed operators are deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11210: Change job submission template from underscores to dashes to conform with k8s naming convention for Dataproc on GKE
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11210:
URL: https://github.com/apache/airflow/pull/11210#issuecomment-792130028
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org