[GitHub] [iceberg] stevenzwu commented on a change in pull request #2863: Flink: Transform INSERT as one DELETE following one INSERT

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #2863:
URL: https://github.com/apache/iceberg/pull/2863#discussion_r695007331



##########
File path: flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java
##########
@@ -63,6 +72,7 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
         .tableLoader(tableLoader)
         .tableSchema(tableSchema)
         .equalityFieldColumns(equalityColumns)
+        .upsert(PropertyUtil.propertyAsBoolean(tableProperties, UPSERT_MODE_ENABLED, UPSERT_MODE_ENABLED_DEFAULT))

Review comment:
       do we need to pass in the table properties for the upsert flag? `FlinkSink.Builder.build()` method internally open the table from TableLoader (if not passed in). Can we extract the prop inside the `build()` method.
   
   Also we probably can add a validation that `upsert` and `overwrite` aren't enabled at the same time?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org