You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/24 17:07:38 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11046: refactor: Remove usages of reactable from TimeTable
kgabryje opened a new pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046
### SUMMARY
The goal is to replace all uses of `reactable-arc` library with DataTable from superset-ui (which uses `react-table` under the hood) and keep the UI/UX mostly unchanged. The reason for that is that `reactable-arc` has been unsupported for 2 years now, uses deprecated lifecycle methods and is incompatible with Typescript.
This PR replaces `reactable-arc` in `TimeTable` component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046#issuecomment-698702816
From the screenshot, wondering why the sparkline isn't expanding to 100% width (?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046#issuecomment-698702816
From the screenshot, wondering why the sparkline isn't expanding to 100% width (?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046#issuecomment-699898435
@mistercrunch Thanks for pointing that out! A style prop for spark column wasn't passed correctly which caused it to have larger width than it should have. Fixed now. I updated the PR summary with the new screenshot.
@rusackas It was my mistake, now the spark column has correct width.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11046: refactor: Remove usages of reactable from TimeTable
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11046:
URL: https://github.com/apache/incubator-superset/pull/11046#issuecomment-699898435
@mistercrunch Thanks for pointing that out! A style prop for spark column wasn't passed correctly which caused it to have larger width than it should have. Fixed now. I updated the PR summary with the new screenshot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org