You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TanaseButcaru <gi...@git.apache.org> on 2016/02/15 20:27:01 UTC
[GitHub] cordova-plugin-camera pull request: Fix FileHelper / port cordova-...
GitHub user TanaseButcaru opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/170
Fix FileHelper / port cordova-plugin-filepath-unofficial and replace getRealPath with it
I recently encountered the ``FileNotFoundException ouputModifiedBitmap`` error while using this plugin and I've tried all PRs available here but none seems to fix the issue.
The current implementation of FileHelper does not deal well with files from external (and even internal) SD card (removable or not).
I also had issues getting videos file paths.
I was using [cordova-plugin-filepath](https://github.com/TanaseButcaru/cordova-plugin-filepath-unofficial) to get the ``file://`` path from a ``content://`` one.
This plugin had its one issues, which I managed to fix & improve it as a whole.
Because the filepath plugin is doing its job well, I ported it to the cordova-plugin-camera. This looks a lot like PR #93 , just that it is updated.
The only case where this fails (as far as I have tested) is the case when user selects a picture/video from Google Drive (there's no solution for this in #143 PR too).
This closes the following:
* #160
* #155
* #149
* #148
* #143
* #135
* #112
* #93
You can test this PR & the #169 PR from my [unofficial version release](https://github.com/TanaseButcaru/cordova-plugin-camera-unofficial) of cordova-plugin-camera.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TanaseButcaru/cordova-plugin-camera-unofficial port-filepath-unofficial
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 72c2f1332f27d2b8f115814de8a978fa8472c0b8
Author: TanaseButcaru <co...@butcaru.com>
Date: 2016-02-15T01:20:06Z
port cordova-plugin-filepath-unofficial and replace getRealPath with it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by swbradshaw <gi...@git.apache.org>.
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
Someone needs to take a look at all the open camera PR. There are many problems with this getRealPath and it has been discussed in a few places. It seems like this PR helps out a lot. For what its worth I removed the need for this function in #197 for most cases. (#197 also allows user to pick a photo from Google Drive.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by davidbarre <gi...@git.apache.org>.
Github user davidbarre commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
#160 #155 #149 #148 #93 are close
#143 #112 are still opened
So what is the status of this PR ?
A bag of thing are in master branch ? is next release planified ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
There's tons of problems with getRealPath, we should be using the FilesProvider to access files instead, since it actually maps to real locations on the disk instead of messing with the MediaStore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #170: Fix FileHelper / port cordova-plugi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by TanaseButcaru <gi...@git.apache.org>.
Github user TanaseButcaru commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
Hi @davidbarre,
At the moment, I don't have the time to continue upgrading my unofficial plugin with version 2.3.
The last time I have made changes to my unofficial plugin, the official implementation wasn't covering all the cases.
I may try to check the differences between my unofficial version and the latest official in the next days.
I'll keep up updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by davidbarre <gi...@git.apache.org>.
Github user davidbarre commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
any update on this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Posted by davidbarre <gi...@git.apache.org>.
Github user davidbarre commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
Hi @TanaseButcaru,
Do you continue to upgrade your unoffical plugin with version 2.3 ?
Or do you consider that version 2.3 of official plugin fix this issues ?
Thanks
--
David
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org