[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6872: Make zookeeper, kafka, controller, broker use random port for integration tests

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #6872:
URL: https://github.com/apache/incubator-pinot/pull/6872#discussion_r625939454



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java
##########
@@ -34,16 +35,22 @@
 public class ZkStarter {
   private static final Logger LOGGER = LoggerFactory.getLogger(ZkStarter.class);
   public static final int DEFAULT_ZK_TEST_PORT = 2191;
-  public static final String DEFAULT_ZK_STR = "localhost:" + DEFAULT_ZK_TEST_PORT;
   private static final int DEFAULT_ZK_CLIENT_RETRIES = 10;
+  private static int ZK_TEST_PORT = 2191;

Review comment:
       Isn't it duplicate with Line 37? If not, what's the purpose of having two ZK test ports?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org