You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Samuel Andrew McIntyre (JIRA)" <de...@db.apache.org> on 2005/05/27 20:48:00 UTC
[jira] Commented: (DERBY-305) Fix error messages in properties files to match text in documentation
[ http://issues.apache.org/jira/browse/DERBY-305?page=comments#action_66486 ]
Samuel Andrew McIntyre commented on DERBY-305:
----------------------------------------------
David's patch committed with minor changes as revision 178809.
> Fix error messages in properties files to match text in documentation
> ---------------------------------------------------------------------
>
> Key: DERBY-305
> URL: http://issues.apache.org/jira/browse/DERBY-305
> Project: Derby
> Type: Sub-task
> Components: Localization
> Versions: 10.0.2.0, 10.0.2.1, 10.0.2.2, 10.1.0.0
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Priority: Trivial
> Attachments: DERBY-305.diff, spelling_grammar_changes.txt, spelling_grammar_changes_with_comments.txt
>
> Jeff has submitted a patch that documents the SQL States and associated error messages, but in the process modified the English text. Now the documentation and messages are out of synch. Rather than adjust the docs to have the old "bad" English, this subtask will adjust the message text to match the "good" English in the documentation.
> If I find any more adjustments are needed, I will note them, and the documentation may need to go through another revision to make sure they match.
> One thought for a future feature: create a script that generates the documentation directly from the message files, or that generates the documentation *and* messages from an independent (XML) source file, so this is not an ongoing exercise...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-305) Fix error messages in properties files to match text in documentation
Posted by Andrew McIntyre <mc...@gmail.com>.
On May 27, 2005, at 2:54 PM, Daniel John Debrunner wrote:
> Samuel Andrew McIntyre (JIRA) wrote:
>
>
>>
>> David's patch committed with minor changes as revision 178809.
>>
>>> Fix error messages in properties files to match text in
>>> documentation
>>>
>
> -1 : remove and re-submit once all test changes have been made in
> the patch.
David,
Can you please review your patch and run derbyall and resubmit with
all changed test canons. I will review the patch again once it is
resubmitted.
Thanks,
andrew
Re: [jira] Commented: (DERBY-305) Fix error messages in properties files to match text in documentation
Posted by Andrew McIntyre <mc...@gmail.com>.
On 5/31/05, Andrew McIntyre <mc...@gmail.com> wrote:
> I'm wondering if the missed step was the 'ant clobber'. I reran a set
> of tests on your patch, and got diffs in 79 tests, from which I am
> attaching derbyall_fail.txt.
Forgot the to attach the file to my previous note. Here it is.
andrew
Re: [jira] Commented: (DERBY-305) Fix error messages in properties
files to match text in documentation
Posted by David Van Couvering <Da...@Sun.COM>.
OK, Andrew, thanks for catching these. One's eyes get a little foggy
after looking at messages for four hours. I'll apply your patch to my
local sandbox, which already has the changes for DERBY-305 applied.
I'll rerun derbyall, see what diffs I get, fix the masters, and then
submit a new patch that captures everything.
David
Andrew McIntyre wrote:
>
> On May 31, 2005, at 10:04 PM, David Van Couvering wrote:
>
>> Hi, Andrew. I don't know what I missed, but I obviously missed it, I
>> got similar results from my run today. I have updated the master
>> directory and am re-running derbyall right now. This is with a fully
>> updated tree that includes the change for DERBY-180.
>
>
> I wish I had remembered to post this sooner, but maybe later is better
> than never. #:-)
>
> I had made some edits to your original patch when I originally reviewed
> it and committed it. I've attached those edits to the JIRA entry as
> DERBY305edits.diff. It's a patch to your patch, hopefully you can get it
> to apply to your DERBY-305.diff. If not, I will try and take care of it
> as a follow-on. The only real problems were message 42X66, where two
> messages appear to have been accidentally concatenated and 42X82, where
> a word was accidentally dropped. The rest are fairly trivial.
>
> andrew
>
Re: [jira] Commented: (DERBY-305) Fix error messages in properties files to match text in documentation
Posted by Andrew McIntyre <mc...@gmail.com>.
On May 31, 2005, at 10:04 PM, David Van Couvering wrote:
> Hi, Andrew. I don't know what I missed, but I obviously missed it,
> I got similar results from my run today. I have updated the master
> directory and am re-running derbyall right now. This is with a
> fully updated tree that includes the change for DERBY-180.
I wish I had remembered to post this sooner, but maybe later is
better than never. #:-)
I had made some edits to your original patch when I originally
reviewed it and committed it. I've attached those edits to the JIRA
entry as DERBY305edits.diff. It's a patch to your patch, hopefully
you can get it to apply to your DERBY-305.diff. If not, I will try
and take care of it as a follow-on. The only real problems were
message 42X66, where two messages appear to have been accidentally
concatenated and 42X82, where a word was accidentally dropped. The
rest are fairly trivial.
andrew
Re: [jira] Commented: (DERBY-305) Fix error messages in properties
files to match text in documentation
Posted by David Van Couvering <Da...@Sun.COM>.
Hi, Andrew. I don't know what I missed, but I obviously missed it, I
got similar results from my run today. I have updated the master
directory and am re-running derbyall right now. This is with a fully
updated tree that includes the change for DERBY-180.
David
Andrew McIntyre wrote:
> On 5/31/05, David Van Couvering <da...@vancouvering.com> wrote:
>
>>I will do a svn update,
>>ant clobber, ant all, and run derbyall and see if I get anything
>>different this time :(
>
>
> I'm wondering if the missed step was the 'ant clobber'. I reran a set
> of tests on your patch, and got diffs in 79 tests, from which I am
> attaching derbyall_fail.txt.
>
> Also, if you're starting clean, you can still get your original patch
> to apply (after my change for Derby-180) by doing:
>
> svn up -r 178826 java/engine/org/apache/derby/loc/messages_en.properties
> patch -p0 < DERBY-305.diff
> svn up
>
> and svn will merge the change for Derby-180 with your patch without conflicts.
>
> andrew
Re: [jira] Commented: (DERBY-305) Fix error messages in properties files to match text in documentation
Posted by Andrew McIntyre <mc...@gmail.com>.
On 5/31/05, David Van Couvering <da...@vancouvering.com> wrote:
> I will do a svn update,
> ant clobber, ant all, and run derbyall and see if I get anything
> different this time :(
I'm wondering if the missed step was the 'ant clobber'. I reran a set
of tests on your patch, and got diffs in 79 tests, from which I am
attaching derbyall_fail.txt.
Also, if you're starting clean, you can still get your original patch
to apply (after my change for Derby-180) by doing:
svn up -r 178826 java/engine/org/apache/derby/loc/messages_en.properties
patch -p0 < DERBY-305.diff
svn up
and svn will merge the change for Derby-180 with your patch without conflicts.
andrew
Re: [jira] Commented: (DERBY-305) Fix error messages in properties
files to match text in documentation
Posted by David Van Couvering <da...@vancouvering.com>.
Well, now, this is a bit stunning. I very carefully ran derbyall and
was surprised to find very few failures given all the changes to error
messages. I was even planning to mention this when I got back from my
trip.
Perhaps I misunderstand how to interpret the output of derbyall? I
checked derbyall.fail, and assumed that all failures would be listed
there. The tests Dan mentioned were not listed there.
I would love some advice to try and help me understand what I missed
here. My apologies for causing test failures. I will do a svn update,
ant clobber, ant all, and run derbyall and see if I get anything
different this time :(
David
Daniel John Debrunner wrote:
> Samuel Andrew McIntyre (JIRA) wrote:
>
>
>> [ http://issues.apache.org/jira/browse/DERBY-305?page=comments#action_66486 ]
>>
>>Samuel Andrew McIntyre commented on DERBY-305:
>>----------------------------------------------
>>
>>David's patch committed with minor changes as revision 178809.
>>
>>
>>
>>>Fix error messages in properties files to match text in documentation
>>>---------------------------------------------------------------------
>
>
> Many error messages changed, but few tests changed. Changing the error
> messages typically will affect test output.
>
> I think I'm seeing at least two failures related to this change and that
> was out of the first ten or so tests in derbylang.
>
> lang/LOB.sql
> lang/aggregate.sql
>
>
> -1 : remove and re-submit once all test changes have been made in the patch.
>
>
> Dan.
>
Re: [jira] Commented: (DERBY-305) Fix error messages in properties
files to match text in documentation
Posted by Daniel John Debrunner <dj...@debrunners.com>.
Samuel Andrew McIntyre (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-305?page=comments#action_66486 ]
>
> Samuel Andrew McIntyre commented on DERBY-305:
> ----------------------------------------------
>
> David's patch committed with minor changes as revision 178809.
>
>
>>Fix error messages in properties files to match text in documentation
>>---------------------------------------------------------------------
Many error messages changed, but few tests changed. Changing the error
messages typically will affect test output.
I think I'm seeing at least two failures related to this change and that
was out of the first ten or so tests in derbylang.
lang/LOB.sql
lang/aggregate.sql
-1 : remove and re-submit once all test changes have been made in the patch.
Dan.