You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/02 03:02:58 UTC

[GitHub] [kafka] showuon opened a new pull request #9241: Update the javadoc in GroupMetadataManager.scala

showuon opened a new pull request #9241:
URL: https://github.com/apache/kafka/pull/9241


   Add and update the Javadoc in `GroupMetadataManager.scala`
   1. add missing parameters
   2. rename the parameter name to be better understand and consistent ( change from `group` to `groupId`)
   3. fix the wrong return description
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9241: MINOR: Update the javadoc in GroupMetadataManager.scala

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9241:
URL: https://github.com/apache/kafka/pull/9241


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #9241: Update the javadoc in GroupMetadataManager.scala

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9241:
URL: https://github.com/apache/kafka/pull/9241#issuecomment-685260150


   @guozhangwang , could you help review this small PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #9241: MINOR: Update the javadoc in GroupMetadataManager.scala

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9241:
URL: https://github.com/apache/kafka/pull/9241#issuecomment-699737966


   @guozhangwang  , could you help review this small PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #9241: MINOR: Update the javadoc in GroupMetadataManager.scala

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9241:
URL: https://github.com/apache/kafka/pull/9241#issuecomment-693429851


   @guozhangwang  , could you help review this small PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #9241: MINOR: Update the javadoc in GroupMetadataManager.scala

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9241:
URL: https://github.com/apache/kafka/pull/9241#issuecomment-686864276


   `tests/Build/JDK 11` and `tests/Build/JDK 15` test passed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org