You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/08 06:06:01 UTC
[GitHub] [bookkeeper] sijie opened a new pull request #2431: Support SNI routing in bookkeeper
sijie opened a new pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431
Descriptions of the changes in this PR:
### Motivation
Netty supports sending SNI header on TLS handshake (https://github.com/netty/netty/issues/3801#issuecomment-104274440).
This PR uses that Netty feature to send SNI header while connecting to proxy software. So we can add proxy servers (e.g. Envoy, Nginx)
in front of bookies.
### Changes
- Add two configurations: `bookieServiceUri` and `bookieConnectionMode`. So the bookkeeper client can configure how it should connect to bookies.
- Send SNI header on TLS handshake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705589124
@sijie I am not working on TLS, the mechanism of BP-41 is quite generic, so we will be free to support new protocols for the Bookie seamlessly in the future, once the BP-41 is finished (missing a couple of patches currently, but I feel it will be ready for BK 4.12.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijie commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705352209
This is a draft to introduce sending SNI header in bookkeeper client. However, I think we need one more chance to make it work. Because in bookkeeper protocol, we use `STARTTLS` for promoting an insecure connection to TLS secured connection. That means we send requests before `STARTTLS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705397033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-777760700
please update TLS tests with test for SNI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijie commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705585048
@eolivelli Are you working on publishing a pure-TLS endpoint on discovery metadata?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijie commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705594287
@eolivelli okay will look into publishing a pure-TLS endpoint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705397033
Now that we have advanced service discovery (BP-38) and the new BookieId abstraction (BP-41, not yet landed completely) the Bookie could publish a pure-TLS endpoint on discovery metadata (BookieServiceInfo) and then the client could use directly that information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705599104
@sijie PTAL here for the discovery mechanisms (BP-38)
https://github.com/apache/bookkeeper/pull/2214/files
here (BP-41 part 1 - already landed to master branch) the client is now able to leverage BP-38
https://github.com/apache/bookkeeper/pull/2404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijie commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-705352209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2431: Support SNI routing in bookkeeper
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2431:
URL: https://github.com/apache/bookkeeper/pull/2431#issuecomment-717270581
BP-41 has basically landed to master, so this work can move forward
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org