You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/06/17 18:31:44 UTC
[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/721
TS-4470: ASAN stack-buffer-overflow when slow log is enabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/721.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #721
----
commit 91542118bf17b9b07941998dcce748eaf39b6958
Author: Bryan Call <bc...@apache.org>
Date: 2016-06-17T18:30:51Z
TS-4470: ASAN stack-buffer-overflow when slow log is enabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/721#discussion_r67730748
--- Diff: proxy/http/HttpSM.cc ---
@@ -6890,7 +6890,8 @@ HttpSM::update_stats()
int offset = 0;
int skip = 0;
- t_state.hdr_info.client_request.url_print(url_string, sizeof url_string, &offset, &skip);
+ t_state.hdr_info.client_request.url_print(url_string, sizeof(url_string), &offset, &skip);
+ url_string[sizeof(url_string) - 1] = 0; // NULL terminate the string
--- End diff --
Shouldn't this be `url_string[offset] = 0;`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #721: TS-4470: ASAN stack-buffer-overflow when slow log ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/721
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/189/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/721#discussion_r77122696
--- Diff: proxy/http/HttpSM.cc ---
@@ -6890,7 +6890,8 @@ HttpSM::update_stats()
int offset = 0;
int skip = 0;
- t_state.hdr_info.client_request.url_print(url_string, sizeof url_string, &offset, &skip);
+ t_state.hdr_info.client_request.url_print(url_string, sizeof(url_string), &offset, &skip);
+ url_string[sizeof(url_string) - 1] = 0; // NULL terminate the string
--- End diff --
The int HTTPHdr::url_print(char *buff, int length, int *offset, int *skip) only called here, can we define the output buffer ( buff ) is a '\0' terminated string?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/721#discussion_r67789890
--- Diff: proxy/http/HttpSM.cc ---
@@ -6890,7 +6890,8 @@ HttpSM::update_stats()
int offset = 0;
int skip = 0;
- t_state.hdr_info.client_request.url_print(url_string, sizeof url_string, &offset, &skip);
+ t_state.hdr_info.client_request.url_print(url_string, sizeof(url_string), &offset, &skip);
+ url_string[sizeof(url_string) - 1] = 0; // NULL terminate the string
--- End diff --
Yeah, that would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #721: TS-4470: ASAN stack-buffer-overflow when slow log ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/721
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/298/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---