You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by "bigduu (via GitHub)" <gi...@apache.org> on 2025/08/06 12:27:42 UTC
[PR] Add debug logging for client port hijack failures in ZooKeeperServerE… [curator]
bigduu opened a new pull request, #1273:
URL: https://github.com/apache/curator/pull/1273
…mbeddedAdapter
Add debug log for some specify situation to help developer identify the issue location
It's will eat the exception if can't find the `ZooKeeperServerEmbeddedImpl` class in some case, it will makes keep trying startup the zk server with same port. so the unit test will throw the address in used without any useful info.
This change add info for investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add debug logging for client port hijack failures in ZooKeeperServerE… [curator]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1273:
URL: https://github.com/apache/curator/pull/1273#issuecomment-3195331490
> It's will eat the exception if can't find the ZooKeeperServerEmbeddedImpl class in some case
I expect this should be covered by:
https://github.com/apache/curator/blob/master/curator-test/src/main/java/org/apache/curator/test/TestingZooKeeperServer.java#L42-L51
How did you using it ? I expect people use `TestingServer` instead of this directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add debug logging for client port hijack failures in ZooKeeperServerE… [curator]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1273:
URL: https://github.com/apache/curator/pull/1273#issuecomment-4071310975
Agree with @kezhuw.
I'm closing this as invalid. Welcome to provide more information and reopen it/open a new issue/PR if desired @bigduu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add debug logging for client port hijack failures in ZooKeeperServerE… [curator]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1273:
URL: https://github.com/apache/curator/pull/1273#discussion_r2256991102
##########
curator-test/src/main/java/org/apache/curator/test/ZooKeeperServerEmbeddedAdapter.java:
##########
@@ -98,8 +98,9 @@ private boolean hijackClientPort(int port) {
addressField.set(peerConfig, new InetSocketAddress(port));
return true;
}
- } catch (Exception ignored) {
+ } catch (Exception e) {
// swallow hijack failure to accommodate possible upstream changes
+ log.debug("Failed to hijack client port configuration, this may be due to upstream changes", e);
Review Comment:
The error message contains a grammatical error. It should be "Failed to hijack client port configuration; this may be due to upstream changes" (add semicolon) or "Failed to hijack client port configuration. This may be due to upstream changes" (use period and capitalize 'This').
```suggestion
log.debug("Failed to hijack client port configuration. This may be due to upstream changes", e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add debug logging for client port hijack failures in ZooKeeperServerE… [curator]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #1273: Add debug logging for client port hijack failures in ZooKeeperServerE…
URL: https://github.com/apache/curator/pull/1273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org