You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/10 07:26:51 UTC
[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #31:
cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
liuguo09 opened a new pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31
So suppress the nightly and check build warnings with pre-processor directive #warning in GCC.
Signed-off-by: liuhaitao <li...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #31:
cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31#issuecomment-611916783
This PR depends on https://github.com/apache/incubator-nuttx/pull/763. So I'll force-push it again once https://github.com/apache/incubator-nuttx/pull/763 merged to pass check builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #31:
cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option
defaultly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31#discussion_r407060958
##########
File path: cibuild.sh
##########
@@ -289,7 +289,7 @@ function run_builds {
options+="-j $ncpus"
for build in $builds; do
- $nuttx/tools/testbuild.sh $options $build
+ $nuttx/tools/testbuild.sh $options -e -Wno-cpp $build
Review comment:
Should we add "" around -Wno-cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull
request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option
defaultly
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31#discussion_r407163581
##########
File path: cibuild.sh
##########
@@ -289,7 +289,7 @@ function run_builds {
options+="-j $ncpus"
for build in $builds; do
- $nuttx/tools/testbuild.sh $options $build
+ $nuttx/tools/testbuild.sh $options -e -Wno-cpp $build
Review comment:
Now it may be well without "" around since there is only -Wno-cpp flag specified. If more flags specified, we should add "" around such as "-Wno-cpp -Werror".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option
defaultly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #31: cibuild.sh: call testbuild.sh with '-e -Wno-cpp' option defaultly
URL: https://github.com/apache/incubator-nuttx-testing/pull/31#discussion_r407060958
##########
File path: cibuild.sh
##########
@@ -289,7 +289,7 @@ function run_builds {
options+="-j $ncpus"
for build in $builds; do
- $nuttx/tools/testbuild.sh $options $build
+ $nuttx/tools/testbuild.sh $options -e -Wno-cpp $build
Review comment:
Should we add "" around -Wno-cpp?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services