You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/28 22:05:46 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
rkhachatryan opened a new pull request #18556:
URL: https://github.com/apache/flink/pull/18556
Depends on #18552 (merged) and #18555 (under review).
Please ignore all the commits except the last.
cc: @curcur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
}, {
"hash" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335",
"triggerID" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 293730edd7736b2079e97c78e49f2b3b9745c54a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1039674063
Private build passed except `e2e_2_ci_build` phase which passed in PR build, merging.
The build with `changelog=on` (not random) also [passed](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1404&view=results) before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438)
* 6b75f7503a73a9e26571d131411c6836a18367e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18556:
URL: https://github.com/apache/flink/pull/18556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689341
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf (Fri Jan 28 22:09:13 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
}, {
"hash" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335",
"triggerID" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"triggerType" : "PUSH"
}, {
"hash" : "950ba3ef64504bf5bd295fa3ee0a921eb809a7a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31440",
"triggerID" : "950ba3ef64504bf5bd295fa3ee0a921eb809a7a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 293730edd7736b2079e97c78e49f2b3b9745c54a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335)
* 950ba3ef64504bf5bd295fa3ee0a921eb809a7a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31440)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1039298190
Rebased to included the latests fixes, waiting for CI to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dd87df63df7001055e956d73267c06b8ee36650 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1039674063
Private build passed except `e2e_2_ci_build` phase which passed in PR build, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b75f7503a73a9e26571d131411c6836a18367e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455)
* 1dd87df63df7001055e956d73267c06b8ee36650 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18556:
URL: https://github.com/apache/flink/pull/18556#discussion_r800597339
##########
File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -129,6 +129,16 @@ private static void randomizeConfiguration(MiniCluster miniCluster, Configuratio
boolean enabled =
randomize(conf, StateChangelogOptions.ENABLE_STATE_CHANGE_LOG, true, false);
if (enabled) {
+ randomize(
+ conf,
+ StateChangelogOptions.PERIODIC_MATERIALIZATION_INTERVAL,
+ Duration.ofMillis(100),
+ Duration.ofMillis(500),
+ Duration.ofSeconds(1),
+ Duration.ofSeconds(5),
+ Duration.ofMinutes(10),
+ Duration.ofSeconds(
+ Long.MAX_VALUE / 1000 /* max allowed by Duration.toMillis */));
Review comment:
I think you're right, 10 minutes is probably too much, I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18556:
URL: https://github.com/apache/flink/pull/18556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1039674063
Private build passed except `e2e_2_ci_build` phase which passed in PR build, merging.
The build with `changelog=on` (not random) also [passed](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1404&view=results) before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b75f7503a73a9e26571d131411c6836a18367e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438)
* 6b75f7503a73a9e26571d131411c6836a18367e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18556:
URL: https://github.com/apache/flink/pull/18556#discussion_r795130597
##########
File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -129,6 +129,16 @@ private static void randomizeConfiguration(MiniCluster miniCluster, Configuratio
boolean enabled =
randomize(conf, StateChangelogOptions.ENABLE_STATE_CHANGE_LOG, true, false);
if (enabled) {
+ randomize(
+ conf,
+ StateChangelogOptions.PERIODIC_MATERIALIZATION_INTERVAL,
+ Duration.ofMillis(100),
+ Duration.ofMillis(500),
+ Duration.ofSeconds(1),
+ Duration.ofSeconds(5),
+ Duration.ofMinutes(10),
+ Duration.ofSeconds(
+ Long.MAX_VALUE / 1000 /* max allowed by Duration.toMillis */));
Review comment:
This is a good idea.
But do we have ITTests that last more than 10 minutes?
If not I think the last two are equivalent saying that materialization is not played?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b75f7503a73a9e26571d131411c6836a18367e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455)
* 1dd87df63df7001055e956d73267c06b8ee36650 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
}, {
"hash" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335",
"triggerID" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dd87df63df7001055e956d73267c06b8ee36650 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847)
* 293730edd7736b2079e97c78e49f2b3b9745c54a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
}, {
"hash" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dd87df63df7001055e956d73267c06b8ee36650 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847)
* 293730edd7736b2079e97c78e49f2b3b9745c54a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1039298190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
curcur edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1025075490
I've accepted the PR with some comments. LGTM
You can decide with your own judgement whether to keep the last two or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1025075490
I've accepted the PR with some comments.
You can decide with your own judgement whether to keep the last two or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1031406959
Thanks for the review!
I removed the 10-minute option and rebased on the latest master (both required PRs are merged).
Will merge after passing the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30438",
"triggerID" : "1e3b6a5f6914d4e91d7fe39aab84dcbe1eafc8cf",
"triggerType" : "PUSH"
}, {
"hash" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30455",
"triggerID" : "6b75f7503a73a9e26571d131411c6836a18367e7",
"triggerType" : "PUSH"
}, {
"hash" : "1dd87df63df7001055e956d73267c06b8ee36650",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30847",
"triggerID" : "1dd87df63df7001055e956d73267c06b8ee36650",
"triggerType" : "PUSH"
}, {
"hash" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335",
"triggerID" : "293730edd7736b2079e97c78e49f2b3b9745c54a",
"triggerType" : "PUSH"
}, {
"hash" : "950ba3ef64504bf5bd295fa3ee0a921eb809a7a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "950ba3ef64504bf5bd295fa3ee0a921eb809a7a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 293730edd7736b2079e97c78e49f2b3b9745c54a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31335)
* 950ba3ef64504bf5bd295fa3ee0a921eb809a7a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18556: [FLINK-23559][tests] Randomize periodic materialisation interval in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18556:
URL: https://github.com/apache/flink/pull/18556#issuecomment-1024689876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org