You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2025/11/02 02:57:07 UTC
[PR] refactor(common): change create_hashes_from_arrays to accept array references [datafusion]
adriangb opened a new pull request, #18433:
URL: https://github.com/apache/datafusion/pull/18433
## Summary
Refactors `create_hashes_from_arrays` to accept `&[&dyn Array]` instead of `&[ArrayRef]` to avoid unnecessary Arc cloning at call sites.
## Changes
- Modified `create_hashes_from_arrays` signature to accept array references
- Updated all internal call sites in `hash_utils.rs` to eliminate Arc cloning
- Maintained backward compatibility via `create_hashes` wrapper function
- Added comprehensive documentation
## Performance Impact
- Reduces reference counting overhead by avoiding unnecessary Arc increments/decrements
- More direct API for callers who already have array references
## Testing
- ✅ All clippy checks pass with `-D warnings`
- ✅ All existing tests pass (no behavioral changes)
- ✅ 17/17 hash_utils module tests passing
## Part of Multi-PR Strategy
This is **PR1 of 7** in the InList pushdown feature breakdown. See the breakdown plan for details.
**Tier**: Foundation (Tier 1)
**Dependencies**: None (independent)
**Can merge**: As soon as approved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor(common): change create_hashes_from_arrays to accept array references [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed pull request #18433: refactor(common): change create_hashes_from_arrays to accept array references
URL: https://github.com/apache/datafusion/pull/18433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org