You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/01/11 16:22:13 UTC

Review Request 42145: Use tags instead of branches for release candidates.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/
-----------------------------------------------------------

Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
-------

Follow-up from https://reviews.apache.org/r/42117 for release candidate script


Diffs
-----

  build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 

Diff: https://reviews.apache.org/r/42145/diff/


Testing
-------

Ran `./build-support/release/release-candidate` in non-publish mode, verified files and e-mail boilerplate generated.


Thanks,

Bill Farner

Re: Review Request 42145: Use tags instead of branches for release candidates.

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/#review113809
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Jan. 11, 2016, 7:22 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42145/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 7:22 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Follow-up from https://reviews.apache.org/r/42117 for release candidate script
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 
> 
> Diff: https://reviews.apache.org/r/42145/diff/
> 
> 
> Testing
> -------
> 
> Ran `./build-support/release/release-candidate` in non-publish mode, verified files and e-mail boilerplate generated.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 42145: Use tags instead of branches for release candidates.

Posted by John Sirois <js...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/#review113770
-----------------------------------------------------------

Ship it!


Ship It!

- John Sirois


On Jan. 11, 2016, 8:22 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42145/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 8:22 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Follow-up from https://reviews.apache.org/r/42117 for release candidate script
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 
> 
> Diff: https://reviews.apache.org/r/42145/diff/
> 
> 
> Testing
> -------
> 
> Ran `./build-support/release/release-candidate` in non-publish mode, verified files and e-mail boilerplate generated.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 42145: Use tags instead of branches for release candidates.

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/#review113764
-----------------------------------------------------------



build-support/release/release-candidate (line 29)
<https://reviews.apache.org/r/42145/#comment174569>

    I renamed this variable as i found it confusing to have `rc_tag_version` and `current_version_tag` variables.



build-support/release/release-candidate 
<https://reviews.apache.org/r/42145/#comment174571>

    Looking through the commands, i didn't find that the use of `$base_dir` was necessary.  I think the resulting code is simpler without it.


- Bill Farner


On Jan. 11, 2016, 7:22 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42145/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 7:22 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Follow-up from https://reviews.apache.org/r/42117 for release candidate script
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 
> 
> Diff: https://reviews.apache.org/r/42145/diff/
> 
> 
> Testing
> -------
> 
> Ran `./build-support/release/release-candidate` in non-publish mode, verified files and e-mail boilerplate generated.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 42145: Use tags instead of branches for release candidates.

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/#review113778
-----------------------------------------------------------

Ship it!


Master (e4c9c73) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 11, 2016, 3:22 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42145/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 3:22 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Follow-up from https://reviews.apache.org/r/42117 for release candidate script
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 
> 
> Diff: https://reviews.apache.org/r/42145/diff/
> 
> 
> Testing
> -------
> 
> Ran `./build-support/release/release-candidate` in non-publish mode, verified files and e-mail boilerplate generated.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>