You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/04/04 22:32:16 UTC

[jira] [Commented] (CB-6346) [BlackBerry10] Commit node_modules

    [ https://issues.apache.org/jira/browse/CB-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960377#comment-13960377 ] 

ASF GitHub Bot commented on CB-6346:
------------------------------------

Github user jengee commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/152#issuecomment-39608258
  
    This readme file indicates to users that we depend on this. Please correct
    
    https://github.com/blackberry/cordova-blackberry/blame/1139813cd8b7ee4b1a103ada5577cab79b2c39e6/blackberry10/README.md#L51-52



> [BlackBerry10] Commit node_modules
> ----------------------------------
>
>                 Key: CB-6346
>                 URL: https://issues.apache.org/jira/browse/CB-6346
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry
>    Affects Versions: 3.4.0
>            Reporter: Bryan Higgins
>            Assignee: Bryan Higgins
>             Fix For: 3.5.0
>
>
> We should commit node_modules for cordova-blackberry rather than running npm install within the init script. cordova-android has already moved to this model.
> https://www.npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git



--
This message was sent by Atlassian JIRA
(v6.2#6252)