[GitHub] [airflow] ashb commented on a change in pull request #5645: [AIRFLOW-5027] Generalized CloudWatch log grabbing for ECS and SageMaker operators

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5645: [AIRFLOW-5027] Generalized CloudWatch log grabbing for ECS and SageMaker operators
URL: https://github.com/apache/airflow/pull/5645#discussion_r313356687
 
 

 ##########
 File path: airflow/contrib/hooks/sagemaker_hook.py
 ##########
 @@ -230,61 +231,6 @@ def get_conn(self):
         """
         return self.get_client_type('sagemaker')
 
-    def get_log_conn(self):
-        """
-        Establish an AWS connection for retrieving logs during training
-
-        :rtype: CloudWatchLogs.Client
-        """
-        config = botocore.config.Config(retries={'max_attempts': 15})
-        return self.get_client_type('logs', config=config)
-
-    def log_stream(self, log_group, stream_name, start_time=0, skip=0):
 
 Review comment:
   To maintain back-compat here (so we can include this in 1.10.5) could you include a shim that calls the new hook/method and issues a DeprecationWarning

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services