[jira] [Commented] (ZOOKEEPER-1821) very ugly warning when compiling load_gen.c

["Germán Blanco (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830609#comment-13830609 ] 

Germán Blanco commented on ZOOKEEPER-1821:
------------------------------------------

The patch adds "return ZOK" in the end of the functions.
There are no new tests (there is no change in behaviour at all, only the warning is removed).

> very ugly warning when compiling load_gen.c
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1821
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1821
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.6, 3.5.0
>         Environment: macos
>            Reporter: Germán Blanco
>            Assignee: Germán Blanco
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1821.patch
>
>
> this is the compiler output:     
> 3.4/src/c/src/load_gen.c:110:1: warning: control may reach end of non-void function [-Wreturn-type]
>      [exec] }
>      [exec] ^
> 3.4/src/c/src/load_gen.c:135:1: warning: control may reach end of non-void function [-Wreturn-type]
>      [exec] }
>      [exec] ^
> 3.4/src/c/src/load_gen.c:163:1: warning: control may reach end of non-void function [-Wreturn-type]
>      [exec] }
>      [exec] ^
> 3.4/src/c/src/load_gen.c:180:1: warning: control may reach end of non-void function [-Wreturn-type]
>      [exec] }
>      [exec] ^
> i think that the code is missing a "return ZOK" in the end of these functions.



--
This message was sent by Atlassian JIRA
(v6.1#6144)