[GitHub] [spark] shahidki31 commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary should only contain successful tasks' metrics

[GitBox <gi...@apache.org>]

shahidki31 commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary should only contain successful tasks' metrics
URL: https://github.com/apache/spark/pull/25369#discussion_r312588354
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
 ##########
 @@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
     // cheaper for disk stores (avoids deserialization).
     val count = {
       Utils.tryWithResource(
-        if (store.isInstanceOf[InMemoryStore]) {
+        if (isInMemoryStore) {
 
 Review comment:
   May be we need to add a test in the AppStatusStoreSuite? There all the stores are tested against InMemory store only, I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org