You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/11 11:48:28 UTC

[GitHub] [kafka] tang7526 commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.

tang7526 commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r726044536



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
                               final Serde<V> valueSerde,
                               final Time time) {
         super(storeSupplier.name(), keySerde, valueSerde, time);
-        Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");

Review comment:
       @abbccdda It's already done, thanks your comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org