[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19325: Numpy take large tensor fix

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #19325:
URL: https://github.com/apache/incubator-mxnet/pull/19325#discussion_r503744174



##########
File path: src/operator/tensor/indexing_op.h
##########
@@ -222,8 +222,8 @@ struct TakeNonzeroAxis {
    */
   template<typename DType, typename IType>
   MSHADOW_XINLINE static void Map(index_t i, DType* out_data, const DType* in_data,
-                                  const IType* idx, const int out_prev_stride,
-                                  const int in_prev_stride, const int in_stride,
+                                  const IType* idx, const index_t out_prev_stride,
+                                  const index_t in_prev_stride, const index_t in_stride,
                                   const int in_ndims, const int out_ndims, const int idx_ndims,
                                   const int axis_dim, const int axis) {
     // i is the global flattened index in the output

Review comment:
       can you change other indices in the code to index_t instead of `int64_t`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org