You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Hussain Towaileb (Code Review)" <do...@asterixdb.incubator.apache.org> on 2019/02/27 21:35:13 UTC
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Hussain Towaileb has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3230
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
[NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Added documentation for BreakSelectIntoConjunctsRule.
- Renamed some variables for easier readability and maintenance.
Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
---
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
1 file changed, 80 insertions(+), 32 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/30/3230/1
diff --git a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
index ab665b3..90aa583 100644
--- a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
+++ b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
@@ -34,9 +34,24 @@
import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
import org.apache.hyracks.api.exceptions.SourceLocation;
+/**
+ * This rule breaks the select operator condition into conjuncts and create a different select operator per conjunct
+ * when applicable.
+ *
+ * Example (simplified):
+ * Before:
+ * select (and(lt($$test.getField("id"), 100), lt($$test.getField("groupId"), 20)))
+ * unnest $$test <- dataset("test.test")
+ *
+ * After:
+ * select (lt($$test.getField("id"), 100))
+ * select (lt($$test.getField("groupId"), 20))
+ * unnest $$test <- dataset("test.test")
+ */
public class BreakSelectIntoConjunctsRule implements IAlgebraicRewriteRule {
- private List<Mutable<ILogicalExpression>> conjs = new ArrayList<Mutable<ILogicalExpression>>();
+ // Conjuncts of the select operator condition
+ private List<Mutable<ILogicalExpression>> conditionConjuncts = new ArrayList<>();
@Override
public boolean rewritePost(Mutable<ILogicalOperator> opRef, IOptimizationContext context) {
@@ -44,47 +59,80 @@
}
@Override
- public boolean rewritePre(Mutable<ILogicalOperator> opRef, IOptimizationContext context)
+ public boolean rewritePre(Mutable<ILogicalOperator> operatorRef, IOptimizationContext context)
throws AlgebricksException {
- AbstractLogicalOperator op = (AbstractLogicalOperator) opRef.getValue();
- if (op.getOperatorTag() != LogicalOperatorTag.SELECT) {
- return false;
- }
- SelectOperator select = (SelectOperator) op;
+ // Operator reference
+ AbstractLogicalOperator operator = (AbstractLogicalOperator) operatorRef.getValue();
- ILogicalExpression cond = select.getCondition().getValue();
-
- conjs.clear();
- if (!cond.splitIntoConjuncts(conjs)) {
+ // Bail if it's not a select operator
+ if (operator.getOperatorTag() != LogicalOperatorTag.SELECT) {
return false;
}
- SourceLocation sourceLoc = select.getSourceLocation();
+ // Select operator
+ SelectOperator originalSelectOperator = (SelectOperator) operator;
- Mutable<ILogicalOperator> childOfSelect = select.getInputs().get(0);
- boolean fst = true;
- ILogicalOperator botOp = select;
- ILogicalExpression firstExpr = null;
- for (Mutable<ILogicalExpression> eRef : conjs) {
- ILogicalExpression e = eRef.getValue();
- if (fst) {
- fst = false;
- firstExpr = e;
+ // Select operator condition
+ ILogicalExpression selectCondition = originalSelectOperator.getCondition().getValue();
+
+ // Clear the condition conjuncts
+ conditionConjuncts.clear();
+
+ // Break the condition into conjuncts, bail if it's not applicable
+ if (!selectCondition.splitIntoConjuncts(conditionConjuncts)) {
+ return false;
+ }
+
+ // Source location
+ SourceLocation sourceLoc = originalSelectOperator.getSourceLocation();
+
+ // Reference to the input of the original select operator
+ Mutable<ILogicalOperator> inputOfOriginalSelectOperator = originalSelectOperator.getInputs().get(0);
+
+ // First expression read of the conjuncts, this will be set to the original select operator at the end
+ boolean first = true;
+ ILogicalExpression firstExpression = null;
+
+ // Bottom operator points to the original select operator at first
+ ILogicalOperator bottomOperator = originalSelectOperator;
+
+ // Start creating the select operators for the condition conjuncts
+ for (Mutable<ILogicalExpression> expressionRef : conditionConjuncts) {
+ ILogicalExpression expression = expressionRef.getValue();
+
+ // Hold reference to the first condition
+ if (first) {
+ first = false;
+ firstExpression = expression;
} else {
- SelectOperator newSelect = new SelectOperator(new MutableObject<ILogicalExpression>(e),
- select.getRetainMissing(), select.getMissingPlaceholderVariable());
+ // New select operator
+ SelectOperator newSelect =
+ new SelectOperator(new MutableObject<>(expression), originalSelectOperator.getRetainMissing(),
+ originalSelectOperator.getMissingPlaceholderVariable());
newSelect.setSourceLocation(sourceLoc);
- List<Mutable<ILogicalOperator>> botInpList = botOp.getInputs();
- botInpList.clear();
- botInpList.add(new MutableObject<ILogicalOperator>(newSelect));
- context.computeAndSetTypeEnvironmentForOperator(botOp);
- botOp = newSelect;
+
+ // Put the new operator at the bottom (child of current operator)
+ List<Mutable<ILogicalOperator>> bottomOperatorInputList = bottomOperator.getInputs();
+ bottomOperatorInputList.clear();
+ bottomOperatorInputList.add(new MutableObject<>(newSelect));
+
+ // Compute the output type environment
+ context.computeAndSetTypeEnvironmentForOperator(bottomOperator);
+
+ // Bottom operator points to the new operator
+ bottomOperator = newSelect;
}
}
- botOp.getInputs().add(childOfSelect);
- select.getCondition().setValue(firstExpr);
- context.computeAndSetTypeEnvironmentForOperator(botOp);
- context.computeAndSetTypeEnvironmentForOperator(select);
+
+ // Add the original select operator input to the bottom operator
+ bottomOperator.getInputs().add(inputOfOriginalSelectOperator);
+
+ // Assign the first expression to the original operator (top)
+ originalSelectOperator.getCondition().setValue(firstExpression);
+
+ // Compute the output type environment
+ context.computeAndSetTypeEnvironmentForOperator(bottomOperator);
+ context.computeAndSetTypeEnvironmentForOperator(originalSelectOperator);
return true;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9207/ (6/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5315/ (14/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Analytics Compatibility Compilation Successful
https://goo.gl/PKNfvJ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3265/ (8/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5258/ (12/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5555/ (15/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/324/ (16/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Dmitry Lychagin (Code Review)" <do...@asterixdb.incubator.apache.org>.
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3230/2/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java:
Line 90: Mutable<ILogicalOperator> originalSelectOperatorInputs = originalSelectOperator.getInputs().get(0);
minor. SELECT operator only has one input, so we need to rename this variable to: originalSelectOperatorInput
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8125/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9304/ (6/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10836/ (9/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/655/ (11/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2: Contrib+1
BAD Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4059/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5623/ (2/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2: Contrib-2
Analytics Compatibility Tests Failed
https://goo.gl/VbrNh4 : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4059/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/521/ (13/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5251/ (15/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3362/ (10/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Dmitry Lychagin (Code Review)" <do...@asterixdb.incubator.apache.org>.
Dmitry Lychagin has submitted this change and it was merged.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
[NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Added documentation for BreakSelectIntoConjunctsRule.
- Renamed some variables for easier readability and maintenance.
- No actual code/logic changes.
Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3230
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
---
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
1 file changed, 82 insertions(+), 34 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Dmitry Lychagin: Looks good to me, approved
Objections:
Anon. E. Moose #1000171: Violations found
diff --git a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
index ab665b3..0f8bb15 100644
--- a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
+++ b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
@@ -34,57 +34,105 @@
import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
import org.apache.hyracks.api.exceptions.SourceLocation;
+/**
+ * This rule breaks the select operator condition into conjuncts and create a different select operator per conjunct
+ * when applicable.
+ *
+ * Example (simplified):
+ * Before:
+ * select (and(lt($$test.getField("field1"), 100), lt($$test.getField("field2"), 20)))
+ * unnest $$test <- dataset("test.test")
+ *
+ * After:
+ * select (lt($$test.getField("field1"), 100))
+ * select (lt($$test.getField("field2"), 20))
+ * unnest $$test <- dataset("test.test")
+ */
public class BreakSelectIntoConjunctsRule implements IAlgebraicRewriteRule {
- private List<Mutable<ILogicalExpression>> conjs = new ArrayList<Mutable<ILogicalExpression>>();
+ // Conjuncts of the select operator condition
+ private List<Mutable<ILogicalExpression>> selectOperatorConditionConjuncts = new ArrayList<>();
@Override
- public boolean rewritePost(Mutable<ILogicalOperator> opRef, IOptimizationContext context) {
+ public boolean rewritePost(Mutable<ILogicalOperator> operatorRef, IOptimizationContext context) {
return false;
}
@Override
- public boolean rewritePre(Mutable<ILogicalOperator> opRef, IOptimizationContext context)
+ public boolean rewritePre(Mutable<ILogicalOperator> operatorRef, IOptimizationContext context)
throws AlgebricksException {
- AbstractLogicalOperator op = (AbstractLogicalOperator) opRef.getValue();
- if (op.getOperatorTag() != LogicalOperatorTag.SELECT) {
- return false;
- }
- SelectOperator select = (SelectOperator) op;
+ // Expected select operator
+ AbstractLogicalOperator expectedSelectOperator = (AbstractLogicalOperator) operatorRef.getValue();
- ILogicalExpression cond = select.getCondition().getValue();
-
- conjs.clear();
- if (!cond.splitIntoConjuncts(conjs)) {
+ // Bail if it's not a select operator
+ if (expectedSelectOperator.getOperatorTag() != LogicalOperatorTag.SELECT) {
return false;
}
- SourceLocation sourceLoc = select.getSourceLocation();
+ // Select operator
+ SelectOperator originalSelectOperator = (SelectOperator) expectedSelectOperator;
- Mutable<ILogicalOperator> childOfSelect = select.getInputs().get(0);
- boolean fst = true;
- ILogicalOperator botOp = select;
- ILogicalExpression firstExpr = null;
- for (Mutable<ILogicalExpression> eRef : conjs) {
- ILogicalExpression e = eRef.getValue();
- if (fst) {
- fst = false;
- firstExpr = e;
+ // Select operator condition
+ ILogicalExpression selectOperatorCondition = originalSelectOperator.getCondition().getValue();
+
+ // Clear the condition conjuncts
+ selectOperatorConditionConjuncts.clear();
+
+ // Break the condition into conjuncts, bail if it's not applicable
+ if (!selectOperatorCondition.splitIntoConjuncts(selectOperatorConditionConjuncts)) {
+ return false;
+ }
+
+ // Source location
+ SourceLocation sourceLoc = originalSelectOperator.getSourceLocation();
+
+ // Inputs of original select operator
+ Mutable<ILogicalOperator> originalSelectOperatorInputs = originalSelectOperator.getInputs().get(0);
+
+ // First expression read of the conjuncts, this will be set to the original select operator at the end
+ boolean isFirst = true;
+ ILogicalExpression firstExpression = null;
+
+ // Bottom operator points to the original select operator at first
+ ILogicalOperator bottomOperator = originalSelectOperator;
+
+ // Start creating the select operators for the condition conjuncts
+ for (Mutable<ILogicalExpression> expressionRef : selectOperatorConditionConjuncts) {
+ ILogicalExpression expression = expressionRef.getValue();
+
+ // Hold reference to the first condition
+ if (isFirst) {
+ isFirst = false;
+ firstExpression = expression;
} else {
- SelectOperator newSelect = new SelectOperator(new MutableObject<ILogicalExpression>(e),
- select.getRetainMissing(), select.getMissingPlaceholderVariable());
- newSelect.setSourceLocation(sourceLoc);
- List<Mutable<ILogicalOperator>> botInpList = botOp.getInputs();
- botInpList.clear();
- botInpList.add(new MutableObject<ILogicalOperator>(newSelect));
- context.computeAndSetTypeEnvironmentForOperator(botOp);
- botOp = newSelect;
+ // New select operator
+ SelectOperator newSelectOperator =
+ new SelectOperator(new MutableObject<>(expression), originalSelectOperator.getRetainMissing(),
+ originalSelectOperator.getMissingPlaceholderVariable());
+ newSelectOperator.setSourceLocation(sourceLoc);
+
+ // Put the new operator at the bottom (child of current operator)
+ List<Mutable<ILogicalOperator>> bottomOperatorInputs = bottomOperator.getInputs();
+ bottomOperatorInputs.clear();
+ bottomOperatorInputs.add(new MutableObject<>(newSelectOperator));
+
+ // Compute the output type environment
+ context.computeAndSetTypeEnvironmentForOperator(bottomOperator);
+
+ // Bottom operator points to the new operator
+ bottomOperator = newSelectOperator;
}
}
- botOp.getInputs().add(childOfSelect);
- select.getCondition().setValue(firstExpr);
- context.computeAndSetTypeEnvironmentForOperator(botOp);
- context.computeAndSetTypeEnvironmentForOperator(select);
+
+ // Add the original select operator inputs to the bottom operator
+ bottomOperator.getInputs().add(originalSelectOperatorInputs);
+
+ // Assign the first expression to the original operator (top)
+ originalSelectOperator.getCondition().setValue(firstExpression);
+
+ // (Re)compute the output type environment
+ context.computeAndSetTypeEnvironmentForOperator(bottomOperator);
+ context.computeAndSetTypeEnvironmentForOperator(originalSelectOperator);
return true;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8125/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1: Contrib+1
BAD Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4009/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5572/ (7/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/162/ (2/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8038/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5216/ (12/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5474/ (4/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10736/ (3/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8038/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/564/ (1/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5929/ (5/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/247/ (5/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/720/ (8/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://goo.gl/MKubsL : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/78/ (16/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5475/ (10/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1: Contrib+1
Analytics Compatibility Tests Successful
https://goo.gl/fZ7UmR : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5254/ (13/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Hussain Towaileb (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/3230
to look at the new patch set (#2).
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
[NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Added documentation for BreakSelectIntoConjunctsRule.
- Renamed some variables for easier readability and maintenance.
- No actual code/logic changes.
Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
---
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/BreakSelectIntoConjunctsRule.java
1 file changed, 82 insertions(+), 34 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/30/3230/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5831/ (9/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/420/ (11/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5161/ (14/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5720/ (3/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/629/ (7/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5353/ (4/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5348/ (1/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule
......................................................................
Patch Set 1:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4009/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No