[jira] Commented: (MSITE-91) "src/site/site.xml" hardcoded in AbstractSiteMojo.java

["Gunther Popp (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MSITE-91?page=comments#action_65505 ] 

Gunther Popp commented on MSITE-91:
-----------------------------------

IMO, this issue should be re-opened. The hard-coded path src/site in AbstractSiteMojo breaks the parameter siteDirectory. In V2.0-beta-4 one could define a custome site-directory, .i.e. doc/site instead of src/site. This doesn´t work any more for V2.0-beta-5 since the plugin looks for the site descriptor excusively in src/site. Hence, it breaks existing build-processes and people have to reorganize their project structure. I am aware that there is no easy fix for this, because of the recursive lookup of site descriptors in parent projects. Personally I think that a new parameter should be introduced that specifies the relative path of the site-descriptor to the basedir of every project (this is, IMO, still better than using a hard-coded relative path).

> "src/site/site.xml" hardcoded in AbstractSiteMojo.java
> ------------------------------------------------------
>
>          Key: MSITE-91
>          URL: http://jira.codehaus.org/browse/MSITE-91
>      Project: Maven 2.x Site Plugin
>         Type: Bug

>     Versions: 2.0-beta-4
>     Reporter: Fabrice BELLINGARD
>     Assignee: Brett Porter
>      Fix For: 2.0-beta-5
>  Attachments: MSITE-91.patch
>
>
> There's a todo in the code, so this issue is more a reminder than an unknown bug.
> In AbstractSiteMojo.java, there's:
>     protected File getSiteDescriptorFile( File basedir, Locale locale )
>     {
>         // TODO: get proper siteDirectory from site configuration of the project this relates to
>         File siteDescriptor = new File( basedir, "src/site/site_" + locale.getLanguage() + ".xml" );
>         if ( !siteDescriptor.exists() )
>         {
>             siteDescriptor = new File( basedir, "src/site/site.xml" );
>         }
>         return siteDescriptor;
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira