You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/20 18:11:48 UTC

[GitHub] [incubator-tvm] szha commented on a change in pull request #6054: [RELAY][MXNET][FRONTEND] add support for MXNET numpy operators

szha commented on a change in pull request #6054:
URL: https://github.com/apache/incubator-tvm/pull/6054#discussion_r457599561



##########
File path: tests/python/frontend/mxnet/test_forward.py
##########
@@ -1373,6 +1374,266 @@ def verify(data_shape, anchor_shape, stds=[1, 1, 1, 1], clip=-1, in_format="corn
     verify((1, 10, 4), (1, 10, 4), in_format="center")
 
 
+dtype_list = ['float64', 'float32', 'int64', 'int32', 'bool']
+
+def test_forward_npi_pad():
+    if not hasattr(mx.sym.np, 'pad'):
+        pytest.skip("mx.sym.np.pad hasn't been publish yet")

Review comment:
       We will need to find a good way to support both mx 1.x and 2.0.
   
   For marking the test, maybe use `@pytest.mark.skipif `?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org