You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by je...@jakarta.apache.org on 2004/08/27 23:01:20 UTC
[jira] Created: (JS1-514) JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JS1-514
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JS1-514
Summary: JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Type: Bug
Status: Unassigned
Priority: Major
Project: Jetspeed
Components:
JSP
Layout
Versions:
1.5
Assignee:
Reporter: Arthur D'Alessandro
Created: Fri, 27 Aug 2004 2:00 PM
Updated: Fri, 27 Aug 2004 2:00 PM
Environment: Tomcat 5.0.19
JVM 1.4.02_04
Windows XPSP2,Linux 2.4
Description:
When maximizing a portlet, and navigating away from the maximized portlet, the new page has the layour (header, left and footer), but the portlet space contains:
<></>
I did see postings from 1.4b3, which indicates a possible fix for similar issue, however, I'm not sure if the fixes were incorporated, or if this is a different issue
Newsgroup thread (from ~ Feb 2004):
After Maximize Protlet, buildNormalContext not Called
Snipplet from posting:
Boyd, David wrote:
"
...
After further investigation, your comments make sense. There seems to be a
bug in the way Jetspeed 1.4b3 handles a portlet when it is maximized,
restored or minimized. After digging around and outputting rundata, saw
that when you maximized a portlet, the js_peid is set to the portlet that is
maximized. When you then select a link off of that page to go to a
completely different psml, the Jetspeed:pane tag lib is called, it checks to
see if the js_peid is set, if so, then it uses that value to look for a
portlet in the psml file, if it is not set then it uses the name to locate
the portlet. Since the psml does not have any portlets with that js_peid,
we get the blank screen.
The solution was to modify the MAXIMAZE, RESTORE and MINIMIZE classes along
with the pane taglib class. Added a new key,value pair to the temp storage
to control the behavior.
..."
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
[jira] Commented: (JS1-514) JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Posted by je...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Arthur D'Alessandro
Created: Mon, 30 Aug 2004 7:36 AM
Body:
Found an issue with the posted patch, where portlets would exhibit strange maximized type behaviour if they were minimized after being maximized and navigating away from the portlet. This updated patch resets the temp var 'js_peid' from the user, thus removing the traces that the portlet had been maximized at any time.
Updated patch:
--- c:\jetspeed-1.5\src\java\org\apache\jetspeed\services\jsp\tags\JetspeedPaneTag.java 2004-04-22 15:35:08.000000000 -0400
+++ JetspeedPaneTag.java 2004-08-30 10:28:26.652585300 -0400
@@ -89,8 +89,15 @@
String jspeid = (String) data.getUser().getTemp("js_peid");
if (jspeid != null)
{
- data.setMode(JetspeedRunData.MAXIMIZE);
- result = jt.getPortletById(jspeid);
+ // See if the returned JSPEID is the current one
+ if (jspeid.equalsIgnoreCase(data.getJs_peid())) {
+ data.setMode(JetspeedRunData.MAXIMIZE);
+ result = jt.getPortletById(jspeid);
+ } else {
+ // Remove the flag for this user
+ data.getUser().removeTemp("js_peid");
+ result = jt.getPane(this.name);
+ }
}
else
{
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JS1-514?page=comments#action_37916
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JS1-514
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JS1-514
Summary: JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Type: Bug
Status: Unassigned
Priority: Major
Project: Jetspeed
Components:
JSP
Layout
Versions:
1.5
Assignee:
Reporter: Arthur D'Alessandro
Created: Fri, 27 Aug 2004 2:00 PM
Updated: Mon, 30 Aug 2004 7:36 AM
Environment: Tomcat 5.0.19
JVM 1.4.02_04
Windows XPSP2,Linux 2.4
Description:
When maximizing a portlet, and navigating away from the maximized portlet, the new page has the layour (header, left and footer), but the portlet space contains:
<></>
I did see postings from 1.4b3, which indicates a possible fix for similar issue, however, I'm not sure if the fixes were incorporated, or if this is a different issue
Newsgroup thread (from ~ Feb 2004):
After Maximize Protlet, buildNormalContext not Called
Snipplet from posting:
Boyd, David wrote:
"
...
After further investigation, your comments make sense. There seems to be a
bug in the way Jetspeed 1.4b3 handles a portlet when it is maximized,
restored or minimized. After digging around and outputting rundata, saw
that when you maximized a portlet, the js_peid is set to the portlet that is
maximized. When you then select a link off of that page to go to a
completely different psml, the Jetspeed:pane tag lib is called, it checks to
see if the js_peid is set, if so, then it uses that value to look for a
portlet in the psml file, if it is not set then it uses the name to locate
the portlet. Since the psml does not have any portlets with that js_peid,
we get the blank screen.
The solution was to modify the MAXIMAZE, RESTORE and MINIMIZE classes along
with the pane taglib class. Added a new key,value pair to the temp storage
to control the behavior.
..."
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
[jira] Commented: (JS1-514) JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Posted by je...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Arthur D'Alessandro
Created: Mon, 30 Aug 2004 6:57 AM
Body:
I have resolved the issue for our implentation by modifying the org.apache.jetspeed.
The excpected impact will be that any navigation away from the current portlet will result in the mode being returned to the normal state.
This resolves our issue where the left navigation bar links to role/group psml's, which were broken when/if portlet was maximized, and a user navigated away from the maximized portlet.
I'd appreciate any comments on how/if the code adjustment above may impact other components of jetspeed.
Thanks,
-Art
Patch:
--- c:\jetspeed-1.5\src\java\org\apache\jetspeed\services\jsp\tags\JetspeedPanag.java 2004-04-22 15:35:08.000000000 -0400
+++ JetspeedPaneTag.java 2004-08-30 09:29:54.844466700 -0400
@@ -89,8 +89,13 @@
String jspeid = (String) data.getUser().getTemp("js_peid");
if (jspeid != null)
{
- data.setMode(JetspeedRunData.MAXIMIZE);
- result = jt.getPortletById(jspeid);
+ // See if the returned JSPEID is the current one
+ if (jspeid.equalsIgnoreCase(data.getJs_peid())) {
+ data.setMode(JetspeedRunData.MAXIMIZE);
+ result = jt.getPortletById(jspeid);
+ } else {
+ result = jt.getPane(this.name);
+ }
}
else
{
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JS1-514?page=comments#action_37915
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JS1-514
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JS1-514
Summary: JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Type: Bug
Status: Unassigned
Priority: Major
Project: Jetspeed
Components:
JSP
Layout
Versions:
1.5
Assignee:
Reporter: Arthur D'Alessandro
Created: Fri, 27 Aug 2004 2:00 PM
Updated: Mon, 30 Aug 2004 6:57 AM
Environment: Tomcat 5.0.19
JVM 1.4.02_04
Windows XPSP2,Linux 2.4
Description:
When maximizing a portlet, and navigating away from the maximized portlet, the new page has the layour (header, left and footer), but the portlet space contains:
<></>
I did see postings from 1.4b3, which indicates a possible fix for similar issue, however, I'm not sure if the fixes were incorporated, or if this is a different issue
Newsgroup thread (from ~ Feb 2004):
After Maximize Protlet, buildNormalContext not Called
Snipplet from posting:
Boyd, David wrote:
"
...
After further investigation, your comments make sense. There seems to be a
bug in the way Jetspeed 1.4b3 handles a portlet when it is maximized,
restored or minimized. After digging around and outputting rundata, saw
that when you maximized a portlet, the js_peid is set to the portlet that is
maximized. When you then select a link off of that page to go to a
completely different psml, the Jetspeed:pane tag lib is called, it checks to
see if the js_peid is set, if so, then it uses that value to look for a
portlet in the psml file, if it is not set then it uses the name to locate
the portlet. Since the psml does not have any portlets with that js_peid,
we get the blank screen.
The solution was to modify the MAXIMAZE, RESTORE and MINIMIZE classes along
with the pane taglib class. Added a new key,value pair to the temp storage
to control the behavior.
..."
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
[jira] Updated: (JS1-514) [FIX] JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Posted by je...@jakarta.apache.org.
The following issue has been updated:
Updater: Jeremy Ford (mailto:jford@apache.org)
Date: Tue, 31 Aug 2004 1:16 PM
Changes:
summary changed from JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser to [FIX] JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/JS1-514?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JS1-514
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JS1-514
Summary: [FIX] JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Type: Bug
Status: Unassigned
Priority: Major
Project: Jetspeed
Components:
JSP
Layout
Fix Fors:
1.6-dev
Versions:
1.5
Assignee:
Reporter: Arthur D'Alessandro
Created: Fri, 27 Aug 2004 2:00 PM
Updated: Tue, 31 Aug 2004 1:16 PM
Environment: Tomcat 5.0.19
JVM 1.4.02_04
Windows XPSP2,Linux 2.4
Description:
When maximizing a portlet, and navigating away from the maximized portlet, the new page has the layour (header, left and footer), but the portlet space contains:
<></>
I did see postings from 1.4b3, which indicates a possible fix for similar issue, however, I'm not sure if the fixes were incorporated, or if this is a different issue
Newsgroup thread (from ~ Feb 2004):
After Maximize Protlet, buildNormalContext not Called
Snipplet from posting:
Boyd, David wrote:
"
...
After further investigation, your comments make sense. There seems to be a
bug in the way Jetspeed 1.4b3 handles a portlet when it is maximized,
restored or minimized. After digging around and outputting rundata, saw
that when you maximized a portlet, the js_peid is set to the portlet that is
maximized. When you then select a link off of that page to go to a
completely different psml, the Jetspeed:pane tag lib is called, it checks to
see if the js_peid is set, if so, then it uses that value to look for a
portlet in the psml file, if it is not set then it uses the name to locate
the portlet. Since the psml does not have any portlets with that js_peid,
we get the blank screen.
The solution was to modify the MAXIMAZE, RESTORE and MINIMIZE classes along
with the pane taglib class. Added a new key,value pair to the temp storage
to control the behavior.
..."
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
[jira] Resolved: (JS1-514) [FIX] JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Posted by je...@jakarta.apache.org.
Message:
The following issue has been resolved as FIXED.
Resolver: Jeremy Ford
Date: Tue, 31 Aug 2004 1:16 PM
Fix applied
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JS1-514
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JS1-514
Summary: [FIX] JSP Maximizing a Portlet, and navigating away from Portlet yields <> in browser
Type: Bug
Status: Resolved
Priority: Major
Resolution: FIXED
Project: Jetspeed
Components:
JSP
Layout
Fix Fors:
1.6-dev
Versions:
1.5
Assignee:
Reporter: Arthur D'Alessandro
Created: Fri, 27 Aug 2004 2:00 PM
Updated: Tue, 31 Aug 2004 1:16 PM
Environment: Tomcat 5.0.19
JVM 1.4.02_04
Windows XPSP2,Linux 2.4
Description:
When maximizing a portlet, and navigating away from the maximized portlet, the new page has the layour (header, left and footer), but the portlet space contains:
<></>
I did see postings from 1.4b3, which indicates a possible fix for similar issue, however, I'm not sure if the fixes were incorporated, or if this is a different issue
Newsgroup thread (from ~ Feb 2004):
After Maximize Protlet, buildNormalContext not Called
Snipplet from posting:
Boyd, David wrote:
"
...
After further investigation, your comments make sense. There seems to be a
bug in the way Jetspeed 1.4b3 handles a portlet when it is maximized,
restored or minimized. After digging around and outputting rundata, saw
that when you maximized a portlet, the js_peid is set to the portlet that is
maximized. When you then select a link off of that page to go to a
completely different psml, the Jetspeed:pane tag lib is called, it checks to
see if the js_peid is set, if so, then it uses that value to look for a
portlet in the psml file, if it is not set then it uses the name to locate
the portlet. Since the psml does not have any portlets with that js_peid,
we get the blank screen.
The solution was to modify the MAXIMAZE, RESTORE and MINIMIZE classes along
with the pane taglib class. Added a new key,value pair to the temp storage
to control the behavior.
..."
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org