You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2012/11/07 19:00:06 UTC

Review Request: Link.delivery() takes offset and size that are not used

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7935/
-----------------------------------------------------------

Review request for qpid and Rob Godfrey.


Description
-------

This patch leaves the signature untouched but throws an exception if the offset is not zero and the length is not the full size of the byte array. It also adds an overloaded version that simply takes a byte array.


This addresses bug QPID-120.
    https://issues.apache.org/jira/browse/QPID-120


Diffs
-----

  /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Link.java 1406092 
  /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java 1406092 

Diff: https://reviews.apache.org/r/7935/diff/


Testing
-------

All existing tests pass.


Thanks,

Gordon Sim