[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4794: Cleanup more raw type List warnings..

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4794:
URL: https://github.com/apache/netbeans/pull/4794#discussion_r996451144


##########
ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/obsolete90/ComplexValueSettingsFactory.java:
##########
@@ -28,11 +28,11 @@
  * @author sdedic
  */
 public class ComplexValueSettingsFactory {
-    public static List getXMLTokenContext() {
+    public static List<XMLDefaultTokenContext> getXMLTokenContext() {

Review Comment:
   This class is not exported and unused in the module - just lets remove the whole class.



##########
ide/xml.core/src/org/netbeans/modules/xml/dtd/grammar/DTDGrammar.java:
##########
@@ -74,7 +74,7 @@ void setResolvedEntities(List/*<String>*/ resolvedEntities) {
         this.resolvedEntities = resolvedEntities;
     }
     
-    public List/*<String>*/ getResolvedEntities() {
+    public List<String> getResolvedEntities() {

Review Comment:
   The generic should also be added to `org.netbeans.modules.xml.api.model.ExtendedGrammarQuery`. Then the cast in `ide/xml.text/src/org/netbeans/modules/xml/text/completion/GrammarManager.java` can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists