You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Zhiguo Wu (Jira)" <ji...@apache.org> on 2023/02/22 10:01:00 UTC
[jira] [Comment Edited] (AMBARI-25859) Correct Ambari Metrics version parsing logic
[ https://issues.apache.org/jira/browse/AMBARI-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692077#comment-17692077 ]
Zhiguo Wu edited comment on AMBARI-25859 at 2/22/23 10:00 AM:
--------------------------------------------------------------
This rolls back AMBARI-13403
https://github.com/apache/ambari-metrics/commit/478866d65737903fd6b4633426a2d2a3d279740d
was (Author: JIRAUSER294567):
This rolls back AMBARI-13403
> Correct Ambari Metrics version parsing logic
> --------------------------------------------
>
> Key: AMBARI-25859
> URL: https://issues.apache.org/jira/browse/AMBARI-25859
> Project: Ambari
> Issue Type: Bug
> Reporter: Zhiguo Wu
> Assignee: Zhiguo Wu
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2023-02-22-16-49-06-587.png
>
>
> Currently Ambari Metrics uses *2.0.0.0-SNAPSHOT* as its version number, and the regex {*}^([0-9]{+})\.([0-9]{+})\.([0-9]{+})\.([0-9]{+})((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).)?{*}* and get *$7* as its release version number, but when we remove *SNAPSHOT* suffix, the parse will return empty value cause build rpm package fails.
>
> If I understand it correctly, the old logic is trying to get number(or word *SNAPSHOT* or {*}techwin{*}) after the symbol "-" as its release version, so I'd like to change the version format to *x.y.z-p* where *x.y.z* means ambari version and *p* means release(or patch) version.(if the branch is under development, we can use *SNAPSHOT* for {*}p{*})
>
> Like this:
> !image-2023-02-22-16-49-06-587.png!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ambari.apache.org
For additional commands, e-mail: issues-help@ambari.apache.org