You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/01/08 12:53:39 UTC
[GitHub] [sling-org-apache-sling-auth-core] rednitish opened a new pull
request #2: Added custom authentication handling
rednitish opened a new pull request #2: Added custom authentication handling
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2
Hi Team,
Currently Basic Auth is supported in case of external request, I found, we should also add custom authentication handler, whereby, if one micro service is providing credential in headers, there should be a way to validate that request as well.
Please let me know, in case more clarification is required.
On a side note, i wanted to have commit access as well on this repository, let me know, in case there are any path, i can follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-auth-core] rednitish commented on issue #2:
custom authentication handling incase credentials are passed through
internal micsroservices within headers
Posted by GitBox <gi...@apache.org>.
rednitish commented on issue #2: custom authentication handling incase credentials are passed through internal micsroservices within headers
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2#issuecomment-572408298
Thank You @kwin & @rombert for the feedback.
I have already created a handler for project purpose, This PR is raised to suggest, what i thought would be useful for community but appreciate your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-auth-core] rednitish closed pull request
#2: custom authentication handling incase credentials are passed through
internal micsroservices within headers
Posted by GitBox <gi...@apache.org>.
rednitish closed pull request #2: custom authentication handling incase credentials are passed through internal micsroservices within headers
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-auth-core] kwin commented on issue #2:
custom authentication handling incase credentials are passed through
internal micsroservices within headers
Posted by GitBox <gi...@apache.org>.
kwin commented on issue #2: custom authentication handling incase credentials are passed through internal micsroservices within headers
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2#issuecomment-572039951
Please rather create your own AuthenticationHandler to deal with project specific requirements. No need to extend the SlingAuthenticator. Just look at https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/HttpBasicAuthenticationHandler.java for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-auth-core] rombert commented on issue #2:
custom authentication handling incase credentials are passed through
internal micsroservices within headers
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #2: custom authentication handling incase credentials are passed through internal micsroservices within headers
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2#issuecomment-572106207
+1 on what @kwin said. Also, you are welcome to submit your custom authentication handler to Sling, so that it used, reviewed and potentially improved by others as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-auth-core] kwin edited a comment on issue
#2: custom authentication handling incase credentials are passed through
internal micsroservices within headers
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on issue #2: custom authentication handling incase credentials are passed through internal micsroservices within headers
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/2#issuecomment-572039951
Please rather create your own AuthenticationHandler to deal with project specific requirements. No need to extend the SlingAuthenticator. Just look at https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/HttpBasicAuthenticationHandler.java for an example. Also please look at https://sling.apache.org/documentation/the-sling-engine/authentication/authentication-authenticationhandler.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services