[GitHub] liubao68 commented on a change in pull request #740: [SCB-595]Compatible with old SC

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #740: [SCB-595]Compatible with old SC
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/740#discussion_r192306341
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/AbstractServiceRegistry.java
 ##########
 @@ -184,6 +184,16 @@ private void loadFrameworkVersions() {
     framework.setVersion(FrameworkVersions.allVersions());
     microservice.setFramework(framework);
     microservice.setRegisterBy(CONFIG_DEFAULT_REGISTER_BY);
+    ServiceCenterInfo info = srClient.getServiceCenterInfo();
+    while (info == null) {
+      return;
+    }
+    String serviceCenterVersion = info.getVersion();
+    String validateSuccessVersion = "1.0.0";
+    int compareResult = serviceCenterVersion.compareTo(validateSuccessVersion);// 如果大于1.0.0，不需要兼容
+    if (compareResult < 1) {
+    microservice.getFramework().setVersion(null);
 
 Review comment:
   In last PR, we have removed this logic, https://github.com/apache/incubator-servicecomb-java-chassis/pull/717/files. What's the difference between this modification? I think they got almost the same issue. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services