[GitHub] [arrow] wjones127 commented on a change in pull request #12751: ARROW-15989: [R] rbind & cbind for Table & RecordBatch

[GitBox <gi...@apache.org>]

wjones127 commented on a change in pull request #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r839803582



##########
File path: r/R/chunked-array.R
##########
@@ -148,6 +153,12 @@ ChunkedArray$create <- function(..., type = NULL) {
   ChunkedArray__from_list(list2(...), type)
 }
 
+#' @export
+c.ChunkedArray <- function(...) {
+  arrays <- list(...)
+  do.call(ChunkedArray$create, unlist(lapply(arrays, function(arr) arr$chunks)))

Review comment:
       So if I modify `ChunkedArray$create()` to accept a chunked array as an argument, it basically becomes it's own `c()` implementation. It also already has a type parameter the handles coercing to a common type, so I think that's handled.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org