You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/07/12 14:16:04 UTC
Review Request 67896: Added container-specific cgroups mount for
freezer & systemd subsystems.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-9070
https://issues.apache.org/jira/browse/MESOS-9070
Repository: mesos
Description
-------
Added container-specific cgroups mount for freezer & systemd subsystems.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
Diff: https://reviews.apache.org/r/67896/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67896: Added container-specific cgroups mount for
freezer & systemd subsystems.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206298
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 19, 2018, 2:10 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 2:10 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9070
> https://issues.apache.org/jira/browse/MESOS-9070
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added container-specific cgroups mount for freezer & systemd subsystems.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/constants.hpp 5be39500828aecad01cbc0e27cb20493048f990e
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
> src/slave/containerizer/mesos/linux_launcher.cpp 3bddcece7028745cec6623ac33dbfcaced629629
>
>
> Diff: https://reviews.apache.org/r/67896/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67896: Added container-specific cgroups mount for
freezer & systemd subsystems.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/
-----------------------------------------------------------
(Updated July 19, 2018, 5:10 p.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9070
https://issues.apache.org/jira/browse/MESOS-9070
Repository: mesos
Description
-------
Added container-specific cgroups mount for freezer & systemd subsystems.
Diffs (updated)
-----
src/slave/containerizer/mesos/constants.hpp 5be39500828aecad01cbc0e27cb20493048f990e
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
src/slave/containerizer/mesos/linux_launcher.cpp 3bddcece7028745cec6623ac33dbfcaced629629
Diff: https://reviews.apache.org/r/67896/diff/2/
Changes: https://reviews.apache.org/r/67896/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67896: Added container-specific cgroups mount for
freezer & systemd subsystems.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 19, 2018, 6:46 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 628 (patched)
> > <https://reviews.apache.org/r/67896/diff/1/?file=2058953#file2058953line628>
> >
> > Should we also use `CGROUP_SEPARATOR` and move it to a common place?
Agree, let me move it to `src/slave/containerizer/mesos/constants.hpp`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206219
-----------------------------------------------------------
On July 12, 2018, 10:16 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 10:16 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9070
> https://issues.apache.org/jira/browse/MESOS-9070
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added container-specific cgroups mount for freezer & systemd subsystems.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
>
>
> Diff: https://reviews.apache.org/r/67896/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67896: Added container-specific cgroups mount for
freezer & systemd subsystems.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206219
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 628 (patched)
<https://reviews.apache.org/r/67896/#comment289109>
Should we also use `CGROUP_SEPARATOR` and move it to a common place?
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 645 (patched)
<https://reviews.apache.org/r/67896/#comment289110>
ditto.
- Gilbert Song
On July 12, 2018, 7:16 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 7:16 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9070
> https://issues.apache.org/jira/browse/MESOS-9070
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added container-specific cgroups mount for freezer & systemd subsystems.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
>
>
> Diff: https://reviews.apache.org/r/67896/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>