[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10195: drivers/virtio: add virtio input driver

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #10195:
URL: https://github.com/apache/nuttx/pull/10195#discussion_r1291587028


##########
drivers/virtio/virtio-input-event-codes.h:
##########
@@ -0,0 +1,926 @@
+/****************************************************************************
+ * drivers/virtio/virtio-input-event-codes.h
+ *
+ * Input event codes
+ *
+ *    *** IMPORTANT ***
+ * This file is not only included from C-code but also from devicetree source
+ * files. As such this file MUST only contain comments and defines.
+ *
+ * Copyright (c) 1999-2002 Vojtech Pavlik
+ * Copyright (c) 2015 Hans de Goede <hd...@redhat.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.

Review Comment:
   virtio-input is modeled as Linux input driver, and explicitly reference this header file in the spec:
   https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-3390008
   and the code comes from include/uapi folder:
   https://github.com/torvalds/linux/blob/master/include/uapi/linux/input-event-codes.h
   All header files in this folder are used and referenced by many userspace library and application which has a special license:
   https://spdx.org/licenses/Linux-syscall-note.html.
   All other code is written from scratch. My question is that where is it safe to directly use the interface definition in header files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org