You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2015/06/11 05:09:15 UTC
[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-js/pull/117
CB 9156 - Move to sibling based platform dependencies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-js CB-9156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 4c09ea70e25b0e2369ab62f3d4924e8f3f150a24
Author: Steve Gill <st...@gmail.com>
Date: 2015-06-11T02:13:00Z
CB-9156 removed platforms as devDependencies, assuming they are siblings instead
commit 18de7d80d5dfbb02ebe940f716a491a5e671ea4c
Author: Steve Gill <st...@gmail.com>
Date: 2015-06-11T03:01:16Z
CB-9156 added ability to pass in custom path via command line for platforms
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/117#issuecomment-111194328
LGTM. Thanks for making this change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-js/pull/117#issuecomment-111261704
I am going to take another pass it this before I commit it. See if I can improve some of the path.join/fs.existSync logic. I also want to test this on Windows + with cordova-lib a little bit more.
For custom paths to platforms, it only takes relative paths right now. I'll see if I can get it to work with absolute paths too.
Readme should be updated more to help committers with making changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org