You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/11/13 15:42:26 UTC

[GitHub] [hbase] Apache-HBase commented on issue #820: HBASE-23286 Improve MTTR: Split WAL to HFile

Apache-HBase commented on issue #820: HBASE-23286 Improve MTTR: Split WAL to HFile
URL: https://github.com/apache/hbase/pull/820#issuecomment-553459807
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 2 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m  9s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 20s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 54s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  master passed  |
   | +0 :ok: |  spotbugs  |   4m  0s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   4m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 19s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 19s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 24s |  hbase-server: The patch generated 9 new + 326 unchanged - 0 fixed = 335 total (was 326)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 33s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 41s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 58s |  the patch passed  |
   | -1 :x: |  findbugs  |   4m 20s |  hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m  2s |  hbase-common in the patch passed.  |
   | +1 :green_heart: |  unit  | 156m 52s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  1s |  The patch does not generate ASF License warnings.  |
   |  |   | 222m  9s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-server |
   |  |  Unchecked/unconfirmed cast from org.apache.hadoop.hbase.wal.WALSplitter$RegionEntryBuffer to org.apache.hadoop.hbase.wal.RecoveredHFileEntryBuffers$HFileRegionEntryBuffer in org.apache.hadoop.hbase.wal.RecoveredHFilesOutputSink.append(WALSplitter$RegionEntryBuffer)  At RecoveredHFilesOutputSink.java:org.apache.hadoop.hbase.wal.RecoveredHFileEntryBuffers$HFileRegionEntryBuffer in org.apache.hadoop.hbase.wal.RecoveredHFilesOutputSink.append(WALSplitter$RegionEntryBuffer)  At RecoveredHFilesOutputSink.java:[line 90] |
   |  |  Should org.apache.hadoop.hbase.wal.RecoveredHFilesOutputSink$SplitWALToHFileTask be a _static_ inner class?  At RecoveredHFilesOutputSink.java:inner class?  At RecoveredHFilesOutputSink.java:[lines 167-191] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-820/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/820 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux d27a61ecccfb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-820/out/precommit/personality/provided.sh |
   | git revision | master / 9494c12e35 |
   | Default Java | 1.8.0_181 |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-820/1/artifact/out/diff-checkstyle-hbase-server.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-820/1/artifact/out/new-findbugs-hbase-server.html |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-820/1/testReport/ |
   | Max. process+thread count | 4916 (vs. ulimit of 10000) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-820/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services