You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/15 11:43:26 UTC
[GitHub] [maven-artifact-plugin] elharo opened a new pull request #3: Maven 3.1.1 minimum
elharo opened a new pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3
@hboutemy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] michael-o commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558258486
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
This contradicts the API version bundled with Maven 3.1.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558855433
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
yes, that's it
the little precision is that it's not a question of classpath order, but a Maven core feature that just skips Maven core provided dependencies: it skips "exported artifacts" from https://maven.apache.org/ref/3.6.3/maven-core/core-extensions.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#issuecomment-761832420
first commit (Maven 3.1.1 minimum) merged
maven-resolver-api version change refused
closing this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] elharo commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558842682
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
Let's see if I understand this. I'm thinking that:
1. When Maven runs to build a user project, it has already loaded maven-resolver-api before it loads this plugin, so it uses the version of maven-resolver-api that is already in the classpath. That could be 1.4.1 for Maven 3.1.1 or some other version with a different version of Maven. Either way, the version declared here is moot. Hence, provided.
2. When this plugin is compiled, though, javac places the version of maven-resolver-api specified here on the classpath.
does that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] slachiewicz commented on pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#issuecomment-761844454
Good question for future can be, what exact version of resolver api we can use in our plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] slachiewicz commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558538486
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
When I compared 1.4.1 and 1.6.1 -api artifact is 100% binary and source compatible. And I think that whatever version we overwrite here - it will be used during compilation only, but Maven runtime will inject version from own lib.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy closed pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
hboutemy closed pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] michael-o commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558562187
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
@slachiewicz That's correct. I still prefer consistency. Just my two cents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] elharo commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558275478
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
Is that a problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558823015
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
perhaps we should mark such dependencies as provided: at least it would explain why we half care (it's not the version we'll have at runtime)
for Maven 4: this is perhaps some case where we could remove one more version tag = "we want to make explicit that we use that library, but with the version that comes from transitive"
I also prefer consistency (with a comment explaining it, because it's not obvious from an external reader point of view)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] slachiewicz commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558538486
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
When I compared 1.4.1 and 1.6.1 -api artifact is 100% binary and source compatible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#issuecomment-761854497
given it is provided by Maven core are runtime, it is purely dependent on Maven minimum version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] michael-o commented on a change in pull request #3: Maven 3.1.1 minimum
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558295275
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
Logically yes. This is contract we guarantee to work from Maven 3.1.1. Resolver API 1.6.1. will arrive with Maven 4 only.
##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
Review comment:
Logically yes. This is contract we guarantee to work from Maven 3.1.1. Resolver API 1.6.1. will arrive with Maven 4 only. Consistency is key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org