You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/04 17:09:26 UTC
[GitHub] [iceberg] pan3793 opened a new pull request #2296: Exclude antlr in spark runtime modules
pan3793 opened a new pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296
Since Spark provide the antlr jars, we should exclude them to avoid class confliction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797071203
I do not have that power :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-792784905
I don't think there is a problem with excluding it in the runtime jar, as long as we keep it in the test jar although perhaps we should add some bulid locking that warns us if the version is changed due to a Spark dep?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797075661
Let me take a look too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797264824
Would you be interested to work on that, @pan3793?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-798046841
> Would you be interested to work on that, @pan3793?
I will open another PR for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 closed pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-796552497
@RussellSpitzer Can you approve and merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797085585
@RussellSpitzer and I had a quick chat.
We exclude all antlr4 dependencies except the runtime jar that is needed for parsing [here](https://github.com/apache/iceberg/blob/900476d62ea599cccfc6e01806b0f02d00ce16af/build.gradle#L962).
So far, we were lucky and it did not cause any conflicts as we are using the same antlr4 version as Spark. However, what if Spark decides to change the version? Then there will be conflicts. We could exclude that jar like this PR does and rely on the jar available in Spark. However, what if Spark bumps its version to something not compatible with what we use? We won't detect it at build time.
It seems the safest option is to actually shade the runtime antlr4 dep and be independent from Spark.
What does everybody think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797214639
Thanks @aokolnychyi clarify, I agree that the ideal solution is relocate antlr4 runtime dependencies, and will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2296: Exclude antlr in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2296:
URL: https://github.com/apache/iceberg/pull/2296#issuecomment-790916694
@aokolnychyi and @RussellSpitzer can you take a look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org