You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/01/23 11:29:55 UTC
[GitHub] incubator-rocketmq pull request #49: [ROCKETMQ-72] DefaultMessageStore canno...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/49
[ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when fa\u2026
\u2026iled in the middle of start()
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
Setting `shutdown` to `false` doesn't seem semantically very correct to me, but without it, message store cannot be properly shutdown.
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-72
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 2b15a5a72c16aa82070f940cf7d329a7460a2c92
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-01-23T11:27:00Z
[ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when failed in the middle of start()
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
It needs a review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
@zhouxinyu I guess you are talking about a shutdown hook that calls `shutdown()`. But the problem remains -- imagine `start()` fails in the middle and even if `shutdown()` is called, no proper termination is done because `this.shutdown` is `true`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
[](https://coveralls.io/builds/9811268)
Coverage decreased (-0.1%) to 29.928% when pulling **e7536ffc961b612cb278b90feb213cc4eb49245a on shroman:ROCKETMQ-72** into **30cabc77bd99abcf934d822d69030ddcfe38f94a on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
[](https://coveralls.io/builds/9795971)
Coverage increased (+0.06%) to 30.133% when pulling **2b15a5a72c16aa82070f940cf7d329a7460a2c92 on shroman:ROCKETMQ-72** into **30cabc77bd99abcf934d822d69030ddcfe38f94a on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
What's going on this pr ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #49: [ROCKETMQ-72] DefaultMessageStore cannot be pr...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
Hi, @shroman , your worry make sense, but if there are some exceptions in `start` process, the JVM will exit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---