[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #2219: IGNITE-19708 Check refcounter of unit before undeploy

["Flaugh24 (via GitHub)" <gi...@apache.org>]

Flaugh24 commented on code in PR #2219:
URL: https://github.com/apache/ignite-3/pull/2219#discussion_r1243690872


##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentUnitAccessorImpl.java:
##########
@@ -36,7 +37,7 @@ public DeploymentUnitAccessorImpl(FileDeployerService deployer) {
      * {@inheritDoc}
      */
     @Override
-    public DisposableDeploymentUnit acquire(DeploymentUnit unit) {
+    public synchronized DisposableDeploymentUnit acquire(DeploymentUnit unit) {

Review Comment:
   I'm not sure that is going to be a bottle neck



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org