[GitHub] [druid] jon-wei commented on issue #9419: SQL: top-level sketch functions do not return sketches

[GitBox <gi...@apache.org>]

jon-wei commented on issue #9419: SQL: top-level sketch functions do not return sketches
URL: https://github.com/apache/druid/issues/9419#issuecomment-594162644
 
 
   @sascha-coenen 
   
   Re: consistency, SQL currently always "finalizes" the aggregators, the specific finalization behavior comes from the underlying implementation of `AggregatorFactory.finalize()`. The HLL and Theta sketches `finalize()` implementations follow the core aggregators `HyperUniquesAggregatorFactory` and `ApproximateHistogramAggregatorFactory` in not returning the serialized sketch (the latter only received an option to finalize as base64 later on, false by default).
   
   Re: control/expressibility, I agree with you, and the issues with using the query context are noted, but I would need to think more about how that functionality would be best expressed/implemented. Maybe having certain "complex" aggs not be finalized by default in SQL, or an approach that you mentioned here:
   
   > This is a huge usability problem and I'm looking forward to writing a proposal for expressing such query hints within the SQL queries.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org