[GitHub] [nifi-minifi-cpp] phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame

[GitBox <gi...@apache.org>]

phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame
URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515515837
 
 
   "honestly I'm against placing the env var to the minifi.sh script. First I don't think we highlight that the script is the only supported way to start the binary, but Nanofi is a more serious concern at the moment: you can configure MiNiFi processors to the flowchain, which would break in such case. It's an edgecase, but still, valid at the moment."
   
   @arpadboda I did  not see this response. Allow me to address this. I am not against codifying this, but we need to be aware that the environment have have already set this and if so have a plan that's reasonable ( i.e. not overriding it ). This transport is not the transport that all streams use. Most common, but not always the case. Therefore a user may and do start processes with that environment variable set. 
   
   NanoFi is a library, no? So this will be implementation specific -- as in binaries produced have the ability to control the entry point of that process. In this case, with initializers, we don't control the entry point. Therefore we have to resolve that. I'm completely okay with alternatives. I've presented two, but have heard nothing to address the concerns or alternatives themselves. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services