[GitHub] [lucene] tang-hi commented on a diff in pull request #12472: Fix UTF32toUTF8 will produce invalid transition

["tang-hi (via GitHub)" <gi...@apache.org>]

tang-hi commented on code in PR #12472:
URL: https://github.com/apache/lucene/pull/12472#discussion_r1280930622


##########
lucene/core/src/test/org/apache/lucene/util/automaton/TestStringsToAutomaton.java:
##########
@@ -142,22 +141,11 @@ private void checkAutomaton(List<BytesRef> expected, Automaton a, boolean isBina
     }
 
     // Make sure every term produced by the automaton is expected
-    FiniteStringsIterator it = new FiniteStringsIterator(a);

Review Comment:
   Because it was added by @gsmiller in https://github.com/apache/lucene/pull/12461 for the purpose of passing the CI test, it should be restored since we have already fixed the bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org