You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "William R. Speirs (JIRA)" <ji...@apache.org> on 2012/10/20 17:46:12 UTC
[jira] [Created] (WICKET-4828) DetailsTable Implementation
William R. Speirs created WICKET-4828:
-----------------------------------------
Summary: DetailsTable Implementation
Key: WICKET-4828
URL: https://issues.apache.org/jira/browse/WICKET-4828
Project: Wicket
Issue Type: New Feature
Components: wicket-extensions
Affects Versions: 6.2.0
Reporter: William R. Speirs
Priority: Minor
This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4828) DetailsTable Implementation
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4828.
-------------------------------------
Resolution: Later
I agree with Sven that Wicket should provide just the base.
The details should stay in the applications.
Thank you for your contribution!
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4828) DetailsTable Implementation
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483610#comment-13483610 ]
Sven Meier commented on WICKET-4828:
------------------------------------
I've send you a pull request on github. I still think this is a highly custom solution that should be solved specific to the project's need.
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4828) DetailsTable Implementation
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483029#comment-13483029 ]
Sven Meier commented on WICKET-4828:
------------------------------------
Thank you very much for your contribution. Although I see the usefulness of such a component, I'm not sure that it is something to be included in Wicket.
Won't anybody show up tomorrow asking for two details rows or two details cells with different colspans?
BTW I don't like the fact that one of the columns should be responsible for the details row. This shows in the following code snippet:
cellItem.getParent().getParent().add(detailsComponent);
The column is inserting its detailsComponent into the markup of its parental table row :/.
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4828) DetailsTable Implementation
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480764#comment-13480764 ]
William R. Speirs commented on WICKET-4828:
-------------------------------------------
I've implemented this type of component and the source can be found here: https://github.com/wspeirs/wicket-details-table
To comply with ASF I can upload the relevant files and click the "accept" box if needed.
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4828) DetailsTable Implementation
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484112#comment-13484112 ]
William R. Speirs commented on WICKET-4828:
-------------------------------------------
I understand why you guys don't want to include it.
Sven, thanks for the pull requests I'll certainly take a look at what you have and probably include it. Thanks again!
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4828) DetailsTable Implementation
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483265#comment-13483265 ]
William R. Speirs commented on WICKET-4828:
-------------------------------------------
I see your point, but would argue that someone asking for 2 details rows could implement that as they can put any component (even another DataTable) inside the details row. As for the other col span, would it be more appealing for me to provide methods to tweak how that work? I figured people who wanted those types of changes would simply extend the class and override the method.
That code snipit did make me cringe just a bit when writing it, but I couldn't find another more elegant way... any thoughts?
In the end, I was looking to make a component that would provide usefulness in 90% of the use cases and provide an example of how to implement such a component if you had other needs such as different colspan, more detail columns, etc...
> DetailsTable Implementation
> ---------------------------
>
> Key: WICKET-4828
> URL: https://issues.apache.org/jira/browse/WICKET-4828
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 6.2.0
> Reporter: William R. Speirs
> Priority: Minor
>
> This ticket is to add a new type of table to wicket-extensions, the DetailsTable. A details table provides an additional row for each table row which provides details about the row above it. The details row can be shown/hidden via a component in a table column.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira