You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/07/31 19:11:49 UTC

[GitHub] [mynewt-core] vrahane commented on a change in pull request #1933: Logging Header Image Hash

vrahane commented on a change in pull request #1933: Logging Header Image Hash
URL: https://github.com/apache/mynewt-core/pull/1933#discussion_r309386764
 
 

 ##########
 File path: sys/log/full/src/log.c
 ##########
 @@ -492,6 +494,18 @@ log_append_prepare(struct log *log, uint8_t module, uint8_t level,
 #else
     assert(etype == LOG_ETYPE_STRING);
 #endif
+#if MYNEWT_VAL(LOG_VERSION) > 3
+
+#if MYNEWT_VAL(LOG_FLAGS_LOG_IMG_HASH)
+    uint8_t hash[IMGMGR_HASH_LEN];
+
+    ue->ue_flags = LOG_FLAGS_LOG_IMG_HASH_e;
+
+    imgr_read_info(0, NULL, hash, NULL);
+    memcpy(ue->ue_rsvd, hash, 4);
+#endif // MYNEWT_VAL(LOG_FLAGS_LOG_IMG_HASH)
 
 Review comment:
   Our coding_style says we do not allow C++ comments. Please remove those or change them into C style comments using `/* */`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services