You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/11/03 15:08:46 UTC
[GitHub] [solr] janhoy opened a new pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
janhoy opened a new pull request #392:
URL: https://github.com/apache/solr/pull/392
https://issues.apache.org/jira/browse/SOLR-15728
Fixes test failure introduced in #375 by removing tests and remains of dead code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742143497
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Via `git grep -n "[^\.\/a-z]utils[^\.\/a-z]"` found reference in `bin/solr.cmd` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #392:
URL: https://github.com/apache/solr/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742244476
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Thanks, I found a `:run_utils` function in solr.cmd that I removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742143497
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Via `git grep -n "[^\.\/a-z]utils[^\.\/a-z]"` found reference in `bin/solr.cmd` file.
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Via `git grep -n "[^\.\/a-z]utils[^\.\/a-z]"` found reference in `bin/solr.cmd` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #392:
URL: https://github.com/apache/solr/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742244476
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Thanks, I found a `:run_utils` function in solr.cmd that I removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742244476
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Thanks, I found a `:run_utils` function in solr.cmd that I removed.
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Thanks, I found a `:run_utils` function in solr.cmd that I removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #392:
URL: https://github.com/apache/solr/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #392:
URL: https://github.com/apache/solr/pull/392#discussion_r742143497
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType))
return new ZkMkrootTool();
else if ("assert".equals(toolType))
return new AssertTool();
- else if ("utils".equals(toolType))
- return new UtilsTool();
Review comment:
Via `git grep -n "[^\.\/a-z]utils[^\.\/a-z]"` found reference in `bin/solr.cmd` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org