You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/03/07 14:28:44 UTC
[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2107
[ZEPPELIN-2149] Each interpreter should have a seperate log file
### What is this PR for?
In the current implementation, both spark and spark2 uses spark interpreter, both phoenix and hive use jdbc interpreter log file.
Each interpreter should have separate log file. The same log file for multiple interpreters confuses the user and complicated debugging.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-2149](https://issues.apache.org/jira/browse/ZEPPELIN-2149)
### How should this be tested?
Create multiple interpreters (say shell interpreter) with different names (say sh1, sh2, etc.).
Now on running these different interpreters should log to different files.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2149
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2107
----
commit 934f27408254f7cd290b6da99b8f12ad95505b30
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-07T14:16:27Z
ZEPPELIN-2149: Each interpreter should have a seperate log file
commit 0cf514fb24c3efac094a1e157e1f5999968d0576
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-07T14:26:25Z
fix tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2107
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2107
Any thoughts on this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2107
I picked up "Interpreter Name" from UI while creating new interpreter, let me rename this to InterpreterGroup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2107
Tested. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2107
[ZEPPELIN-2149] Each interpreter should have a seperate log file
### What is this PR for?
In the current implementation, both spark and spark2 uses spark interpreter, both phoenix and hive use jdbc interpreter log file.
Each interpreter should have separate log file. The same log file for multiple interpreters confuses the user and complicated debugging.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-2149](https://issues.apache.org/jira/browse/ZEPPELIN-2149)
### How should this be tested?
Create multiple interpreters (say shell interpreter) with different names (say sh1, sh2, etc.).
Now on running these different interpreters should log to different files.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2149
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2107
----
commit 934f27408254f7cd290b6da99b8f12ad95505b30
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-07T14:16:27Z
ZEPPELIN-2149: Each interpreter should have a seperate log file
commit 0cf514fb24c3efac094a1e157e1f5999968d0576
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-07T14:26:25Z
fix tests
commit a989f5e355badbc6cdc05f2c2a70e7ee80ef3d50
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-08T08:43:54Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2149
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2107
Is `name` the right name for this? I seem to recall we call it something else in the code for the `%thing`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---